This repository was archived by the owner on May 29, 2026. It is now read-only.
feat(schemas): x-openregister-lifecycle on 7 schemas (re-do of #306)#490
Merged
rubenvdlinde merged 1 commit intoMay 19, 2026
Merged
Conversation
3 tasks
37510ac to
bd01faf
Compare
Contributor
Quality Report — ConductionNL/procest @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| composer | ✅ | ✅ 100/100 | |||
| npm | ✅ | ✅ 420/420 | |||
| PHPUnit | ❌ | ||||
| Newman | ⏭️ | ||||
| Playwright | ❌ |
Quality workflow — 2026-05-19 03:33 UTC
Download the full PDF report from the workflow artifacts.
bd01faf to
1a8ba48
Compare
Contributor
Quality Report — ConductionNL/procest @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| composer | ✅ | ✅ 100/100 | |||
| npm | ✅ | ✅ 420/420 | |||
| PHPUnit | ✅ | ||||
| Newman | ⏭️ | ||||
| Playwright | ❌ |
Coverage: 0% (0/81 statements)
Quality workflow — 2026-05-19 03:51 UTC
Download the full PDF report from the workflow artifacts.
Contributor
Quality Report — ConductionNL/procest @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| composer | ✅ | ✅ 100/100 | |||
| npm | ✅ | ✅ 420/420 | |||
| PHPUnit | ✅ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ |
Coverage: 0% (0/81 statements)
Quality workflow — 2026-05-19 04:09 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(re-opened of #419 — accidentally closed by harness force-push; same branch, same content)
Summary
Re-applies the ADR-031 declarative-state-machine annotations from PR #306 onto the current post-manifest-migration
lib/Settings/procest_register.json. PR #306's branch (feature/declarative-annotation-pilot) accumulated 40+ conflicts withdevelopment(which has since landed the json-manifest migration that deleted/restructured files the branch modified) and could not be rebased — this is a clean re-do off currentdevelopment.Adds
configuration.x-openregister-lifecycleblocks (state machine:field,initial,final,transitions) to 7 schemas, with version bumps:taskdocumentvoorstelhearingSessiondossier_beschikbaarstatus that development added)adviesAanvraaghandhavingsactieinspectieChecklistRegister version bumped 0.7.0 → 0.8.0.
Notes / scope
lib/Lifecycle/), nox-openregister-calculations/-aggregations/-notifications, and noSTATUS_*constant removal — those were never part of that PR — so this re-do mirrors it: register-JSON-only. No PHP changes.docs/development.md,l10n/*,src/utils/taskLifecycle.js) was branch drift, not part of the lifecycle deliverable, and is intentionally not carried over.python3 -m json.tool lib/Settings/procest_register.jsonvalidates.Supersedes #306, which is on an un-rebaseable branch.
Test plan
python3 -m json.tool lib/Settings/procest_register.jsonis valid (done)POST /api/objects/{id}/transitionhonours the new transition tables