This repository was archived by the owner on May 29, 2026. It is now read-only.
fix(#323): clear 6 mechanical ESLint source errors#498
Merged
Conversation
rubenvdlinde
force-pushed
the
fix/323-mechanical-eslint-fixes
branch
from
11795ea to
921b6ae
Compare
Pure no-op cleanup; no semantic change to any view. Six errors fixed:
- src/store/modules/bezwaar.js:499 (no-unused-vars):
remove unused settingsStore + its import.
- src/views/cases/components/CaseTransferDialog.vue:38 (vue/valid-v-slot):
move <template #actions> out of the wrapper <div> to be a direct
child of NcDialog.
- src/views/cases/components/CreateShareDialog.vue:92 (vue/valid-v-slot):
same as above.
- src/views/cases/components/EmailComposer.vue:49,59 (vue/no-parsing-error):
literal '{{' inside {{ }} interpolation confused the template parser;
replaced with a formatVariable(v) method returning the same string.
- src/views/settings/components/DurationPicker.vue:31 (no-unused-vars):
remove unused formatDuration from named import.
The 7th error (vue/no-dupe-v-else-if in MyWork.vue) is intentionally
deferred to a separate PR with explicit fix(my-work) framing because
the fix actually un-blocks dead grouped-sections rendering — needs a
visual smoke-test rather than auto-merge alongside cosmetic noise.
Refs #323; that issue stays open until the MyWork.vue follow-up lands.
rubenvdlinde
force-pushed
the
fix/323-mechanical-eslint-fixes
branch
from
921b6ae to
c796cf8
Compare
Contributor
Quality Report — ConductionNL/procest @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| composer | ✅ | ✅ 100/100 | |||
| npm | ✅ | ✅ 420/420 | |||
| PHPUnit | ❌ | ||||
| Newman | ⏭️ | ||||
| Playwright | ❌ |
Quality workflow — 2026-05-19 03:52 UTC
Download the full PDF report from the workflow artifacts.
Contributor
Quality Report — ConductionNL/procest @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| composer | ✅ | ✅ 100/100 | |||
| npm | ✅ | ✅ 420/420 | |||
| PHPUnit | ✅ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ |
Coverage: 0% (0/81 statements)
Quality workflow — 2026-05-19 04:10 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(re-opened of #327 — accidentally closed by harness force-push; same branch, same content)
Pure no-op cleanup; no semantic change to any view. Six errors fixed: bezwaar.js no-unused-vars (settingsStore), CaseTransferDialog.vue + CreateShareDialog.vue vue/valid-v-slot (move template #actions to direct child of NcDialog), EmailComposer.vue vue/no-parsing-error x2 (literal '{{' inside interpolation -> formatVariable() method), DurationPicker.vue no-unused-vars (formatDuration). 7th error (vue/no-dupe-v-else-if in MyWork.vue) split into separate PR #326 (behaviour change, needs smoke-test). Refs #323.