This repository was archived by the owner on May 29, 2026. It is now read-only.
ci(quality): disable E2E pending nc-vue#242 fix#500
Merged
Conversation
The published @conduction/nextcloud-vue bundle has a hard-coded require('../../store/index.js') that webpack can't resolve in consumer apps, so the procest bundle build fails and every E2E spec then 404s. Disable E2E in code-quality.yml until a beta past the upstream fix is pinned in package.json.
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
Contributor
Quality Report — ConductionNL/procest @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| composer | ✅ | ✅ 100/100 | |||
| npm | ✅ | ✅ 420/420 | |||
| PHPUnit | ✅ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ |
Coverage: 0% (0/81 statements)
Quality workflow — 2026-05-19 04:04 UTC
Download the full PDF report from the workflow artifacts.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The published
@conduction/nextcloud-vue@^1.0.0-beta.42bundle has a hard-codedrequire('../../store/index.js')insideCnObjectDataWidget.vue(wrapped in a soft try/catch) that webpack can't resolve in consumer apps. Procest's bundle build fails (272 errors) and every E2E spec then 404s when the dev server can't serve the JS.This unblocks all PR-level E2E gating until
ConductionNL/nextcloud-vue#242ships a fix and we pin the new beta inpackage.json.