feat(gis): WFS export endpoint for case locations (ports #483)#604
Merged
Conversation
Ports the unique outbound WFS-export capability from PR #483 (feature/462/gis-integration) onto the current development baseline. That branch had diverged from an unrelated history root and could not be merged directly without reverting large amounts of merged dev work, so only the genuinely-unique, self-contained additions are carried over: - lib/Service/WfsExportService.php — builds a GeoJSON FeatureCollection of case locations from OpenRegister (uses SettingsService.getObjectService + findObjects, already on dev) plus a WFS GetCapabilities descriptor. - lib/Controller/WfsExportController.php — GET /api/gis/wfs (GetFeature) and /api/gis/wfs/capabilities, NoAdminRequired with an authenticated- session guard, typeName/outputFormat/maxFeatures/bbox/status/caseType params. - appinfo/routes.php — two additive wfsExport routes alongside the existing gis_proxy / wms_wfs proxy routes. - Unit tests for both classes. This complements dev's existing proxy-based GIS work (GisProxy/WmsWfs); the WFS export (procest cases AS a layer) was absent on dev.
rubenvdlinde
requested review from
WilcoLouwerse,
bbrands02 and
rjzondervan
as code owners
May 25, 2026 15:37
Contributor
Quality Report — ConductionNL/procest @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ❌ | ||||
| phpcs | ❌ | ||||
| phpmd | ❌ | ||||
| psalm | ❌ | ||||
| phpstan | ❌ | ||||
| phpmetrics | ❌ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| composer | ❌ | ❌ | |||
| npm | ✅ | ✅ 426/426 | |||
| PHPUnit | ⏭️ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ |
Quality workflow — 2026-05-25 15:39 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports the unique outbound WFS-export capability from #483 onto the current
developmentbaseline.#483's branch (
feature/462/gis-integration) had diverged from an unrelated history root (~117 commits behind dev) and could not be merged directly without reverting merged dev work. Only the genuinely-unique, self-contained additions are carried over here:lib/Service/WfsExportService.php— GeoJSON FeatureCollection of case locations + WFS GetCapabilities descriptor (usesSettingsService.getObjectService()+findObjects(), already on dev).lib/Controller/WfsExportController.php—GET /api/gis/wfs(GetFeature) and/api/gis/wfs/capabilities;@NoAdminRequiredwith an authenticated-session guard;typeName/outputFormat/maxFeatures/bbox/status/caseTypeparams.appinfo/routes.php— two additivewfsExportroutes.This complements dev's existing proxy-based GIS work (
GisProxy/WmsWfs); the WFS export (procest cases AS a layer) was absent on dev.Test plan
composer check:strictGET /api/gis/wfsreturns a GeoJSON FeatureCollection;/capabilitiesreturns the descriptorCloses #483.