This repository was archived by the owner on May 29, 2026. It is now read-only.
fix(security): clear Bucket-B (ADR-023 + auth/routing)#627
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clears Bucket-B security gates for procest per ADR-022/ADR-023. Fixes gates 5, 6, 7, 9, 14 only. Gate-17 (redundant-controller) passed as a bonus.
Closes #625
Gate-by-gate before → after
Pre-existing failures not in scope (left red): gate-3 stub-scan (
BerichtenboxReadStatusJob), gate-8 unsafe-auth-resolver (2 sites inZgwService).Auth posture summary (ADR-023)
AiController,CaseDefinitionController,ParafeerRouteController,SettingsController,TenantController,ZgwMappingController#[AuthorizedAdminSetting(Application::APP_ID)]AcController,BrcController,DrcController,NrcController,ZrcController,ZtcController,StufController@NoAdminRequiredfrom@PublicPagemethods@NoAdminRequired+Http::STATUS_UNAUTHORIZEDguardRoutes changed
parafeer_actie→parafeerActie,zgw_mapping→zgwMapping,case_definition→caseDefinition,gis_proxy→gisProxy,wms_wfs→wmsWfs,parafeer_route→parafeerRoute,parafering_audit_export→paraferingAuditExport,status_transition→statusTransition,public_appointment→publicAppointmentBerichtenboxController,ConsultationController,EmailController,TemplateController,MilestoneControllerGate-6 orphan removal
Three truly-orphaned methods with zero callers were removed entirely (rather than made private to avoid PHPStan unused-method errors):
ChecklistService::validateCompletionTenantService::isUserInTenantWmsWfsService::validateLayer(and its privateisUrlAllowedhelper)PHPStan
Baseline regenerated to suppress the known fleet FP (
AuthorizedAdminSettingclass-string —Application::APP_IDis astringnot aclass-string<IDelegatedSettings>; same FP as all other fleet apps).Result:
[OK] No errors