This repository was archived by the owner on May 29, 2026. It is now read-only.
fix: bring CI green — PHPCS 0 errors, Psalm 0 errors, PHPUnit 153/153#658
Merged
Merged
Conversation
PHPUnit: Add IUserSession mock to GisProxyControllerTest setUp; configure getUser() to return a non-null IUser so all 7 controller tests pass. PHPCS: Run phpcbf (auto-fixed 1,549 of 3,462 errors); merge 515 standalone @SPEC docblocks into their preceding full docblocks (the retrofit spec work left a dual-docblock anti-pattern that PHPCS counted as missing short-desc / @return / @param); hand-fix 2 remaining `!` operator violations. Psalm: Cast DOMNodeList->item(0) to DOMElement before calling getElementsByTagName (StufController ×3); add @psalm-suppress UnusedParam to 3 private methods with intentionally unused future-use params; suppress InvalidTemplateParam on ParaferingAuditAppendOnlyValidator; baseline ObjectDeletingEvent, LockedException, Db\Mapping, ZgwController, OC_Util as OR-peer / NC-internal stub gaps in psalm.xml.
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IUserSessionmock toGisProxyControllerTest::setUp(); configuregetUser()to return a non-null mock so all 7 tests pass (was: 7 ArgumentCountError failures)@specdocblocks into their preceding full docblocks (retrofit spec work left dual-docblock anti-pattern that PHPCS saw as missing short-desc/@return/@param); hand-fixed 2!operator violations inParaferingAuditListenerandWfsExportServiceDOMNodeList->item(0)toDOMElementbefore callinggetElementsByTagNameinStufController(×3); add@psalm-suppress UnusedParamto 3 private methods with intentional future-use params; suppressInvalidTemplateParamonParaferingAuditAppendOnlyValidator; baselineObjectDeletingEvent,LockedException,Db\Mapping,ZgwController,OC_Utilas OR-peer/NC-internal stub gaps inpsalm.xmlBefore / After
Deferred (architectural debt, not in scope)