This repository was archived by the owner on May 29, 2026. It is now read-only.
fix: make composer check:strict pass on development#670
Merged
Conversation
PHPStan: removed 4 dead-code is_array===false guards (HearingService,
GuardRegistry, SideEffectDispatcher, WfsExportService, ChecklistService
×2); extracted caseId before status mutation in CaseTransferService;
removed redundant ?? on array{passed:bool} in GuardRegistry::allPassed;
removed always-true || in ParaferingAuditAppendOnlyValidator catch block;
removed stale baseline entry for ChecklistService.
Added missing CaseSharingService::revokeShare() and
getFilteredCaseData() methods (called by CaseSharingController and
PublicShareController); added requiresPassword to validateToken return
type so PublicShareController::accessShare password-gate compiles clean.
gate-9 semantic-auth: dropped @publicpage from AcController::create,
update, patch, destroy — JWT body-check is authoritative, NC default
non-public protects the routes correctly.
PHPCS: fixed inline-IF ternary in CaseTransferService, CaseSharingService,
InspectionController (×4); fixed assignment-alignment in
InspectionController (×3); added missing //end try comments in
InspectionController (×2) and ZgwService; removed blank line after
inline comment in ZgwService.
ESLint: auto-fixed 8 vue/max-attributes-per-line and vue/html-indent
errors across Vue/JS sources.
All 171 PHPUnit tests pass; composer check:strict exits 0.
rubenvdlinde
requested review from
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan