Skip to content
This repository was archived by the owner on May 29, 2026. It is now read-only.
This repository was archived by the owner on May 29, 2026. It is now read-only.

[MEDIUM] M2: performScheduledSync full-sync branch is empty — full syncs never execute #342

Description

@rubenvdlinde

Severity: MEDIUM

Location: lib/Service/OrganizationSyncService.php lines 2818–2820 (performScheduledSync)

Description:
The block that should switch syncMode to 'full' when $minutesBack === 0 has an empty body:

if ($minutesBack === 0) {
    // empty — syncMode never set to 'full'
}

The intended full-sync path is never triggered. Scheduled full syncs silently fall back to incremental mode, giving operators a false impression that a complete re-sync ran when it did not.

Suggested fix:
Implement the body:

if ($minutesBack === 0) {
    $syncMode = 'full';
}

Source: deep team-reviewer pass 2026-05-27

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions