Skip to content
This repository was archived by the owner on May 29, 2026. It is now read-only.

retrofit: reverse-spec organisatie-service (5 REQs / 8 methods)#292

Merged
rubenvdlinde merged 1 commit into
developmentfrom
retrofit/reverse-spec-softwarecatalog-organisatie-service-2026-05-24
May 25, 2026
Merged

retrofit: reverse-spec organisatie-service (5 REQs / 8 methods)#292
rubenvdlinde merged 1 commit into
developmentfrom
retrofit/reverse-spec-softwarecatalog-organisatie-service-2026-05-24

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

Retrofit — Reverse-Spec

Describes observed behavior of 8 methods in OrganisatieService as 5 new REQs under a new organisatie-service capability.

Ghost change: retrofit-2026-05-24-organisatie-service.

What this PR does

  • Drafts 5 REQs: create OR entity, status update + status enum mapping, SC->OR payload mapping, user assignment + notifications, admin group lookup
  • Annotates 8 methods with @spec tags
  • Captures the no-propagate / log-and-return-null-or-false error contract

What this PR does NOT do

  • No code behavior changes — annotations only
  • Does not restore parent-organisation HOTFIX (RBAC issue, flagged in Notes)
  • Does not consolidate the three organisation-touching services (out of scope)

Review focus

  • mapStatus() enum table (active/inactive/unknown→active default)
  • naam fallback chain in mapOrganizationDataForOpenRegister

Source: `openspec/coverage-report.md` generated 2026-05-24 | Cluster: `organisatie-service` (Bucket 2b)

Umbrella: #285

Reverse-spec for OrganisatieService (SC<->OR organisation integration
layer). New 'organisatie-service' capability with 5 REQs: create OR
entity, update status + status enum mapping, map SC->OR payload, add
users with email notification, list admin group usernames.

Notes flag the disabled parent-organisation HOTFIX (RBAC issue) and
redundant exception logging in addUsersToOrganization for follow-up.

Refs #285
@rubenvdlinde rubenvdlinde added openspec OpenSpec-driven change yolo Auto-merge when all phases pass retrofit Retrofit playbook reverse-spec labels May 24, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/softwarecatalog @ 9c7f6bb

Check PHP Vue Security License Tests
lint
phpcs
phpmd
psalm
phpstan
phpmetrics
eslint
stylelint
composer
npm ❌ 2/846 denied
PHPUnit ⏭️
Newman ⏭️
Playwright ⏭️

❌ Denied npm licenses

Package Version License
pako 1.0.11 (MIT AND Zlib)
sha.js 2.4.12 (MIT AND BSD-3-Clause)

Quality workflow — 2026-05-24 18:54 UTC

Download the full PDF report from the workflow artifacts.

@rubenvdlinde rubenvdlinde merged commit d3e2d28 into development May 25, 2026
11 of 21 checks passed
@rubenvdlinde rubenvdlinde deleted the retrofit/reverse-spec-softwarecatalog-organisatie-service-2026-05-24 branch May 25, 2026 07:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

openspec OpenSpec-driven change retrofit Retrofit playbook reverse-spec yolo Auto-merge when all phases pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant