This repository was archived by the owner on May 29, 2026. It is now read-only.
retrofit: extend method-decomposition with SettingsController public API (5 REQs / 18 methods)#293
Merged
rubenvdlinde merged 1 commit intoMay 25, 2026
Conversation
…API (REQ-DECOMP-013..017) Extends method-decomposition capability with 5 retrofit REQs covering 18 SettingsController public methods that fall outside REQ-DECOMP-001's named scope. Groupings: settings CRUD / config bootstrap+status / sync orchestration / cache+heartbeat diagnostics / progress streaming. Notes flag 3 concrete bugs spotted during reverse-spec: empty-if blocks inverting HTTP status codes in performSync (always 500 on incremental success) and resetAutoConfig (always 400 on success), plus missing @NoAdminRequired on the general config endpoints. 23 remaining SettingsController _misc_ methods + Service-side misc clusters deferred to future retrofit passes. Refs #285
Contributor
Quality Report — ConductionNL/softwarecatalog @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ❌ | ||||
| phpcs | ❌ | ||||
| phpmd | ❌ | ||||
| psalm | ❌ | ||||
| phpstan | ❌ | ||||
| phpmetrics | ❌ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| composer | ❌ | ❌ | |||
| npm | ✅ | ❌ 2/846 denied | |||
| PHPUnit | ⏭️ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ |
❌ Denied npm licenses
| Package | Version | License |
|---|---|---|
| pako | 1.0.11 | (MIT AND Zlib) |
| sha.js | 2.4.12 | (MIT AND BSD-3-Clause) |
Quality workflow — 2026-05-24 18:59 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retrofit — Reverse-Spec (extend)
Extends the existing
method-decompositioncapability with 5 retrofit REQs (REQ-DECOMP-013..017) covering 18 SettingsController public methods that fall outside REQ-DECOMP-001's named scope.Ghost change:
retrofit-2026-05-24-method-decomposition. Frontmatter uses block-YAMLretrofit_extensions: [REQ-DECOMP-013..017].What this PR does
@spectagsperformSync(incremental success returns 500) andresetAutoConfig(success returns 400), plus missing@NoAdminRequiredon general config endpoints. Same bug pattern as PR retrofit: reverse-spec progress-tracking (5 REQs / 9 methods) #288'sprogress-tracking#calculateOverallPercentage.What this PR does NOT do
Review focus
Source: `openspec/coverage-report.md` generated 2026-05-24 | Cluster: `method-decomposition` (Bucket 2a)
Umbrella: #285