Skip to content
This repository was archived by the owner on May 29, 2026. It is now read-only.

retrofit(coverage): spec-coverage to zero uncovered methods #301

Merged
rubenvdlinde merged 3 commits into from
May 25, 2026
Merged

retrofit(coverage): spec-coverage to zero uncovered methods #301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
637a2fd
retrofit(coverage): reverse-spec + annotate backend to 0 uncovered
rubenvdlinde May 25, 2026
99fd3d4
Merge remote-tracking branch 'origin/development' into retrofit/cover…
rubenvdlinde May 25, 2026
c8e1d51
retrofit(coverage): reverse-spec + annotate frontend to 0 uncovered
rubenvdlinde May 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/BackgroundJob/CronjobContextTrait.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ trait CronjobContextTrait
* @param string $jobId The identifier of the cronjob (e.g., 'organization_contact_sync')
*
* @return bool True if context was successfully set, false otherwise
* @spec openspec/changes/retrofit-2026-05-26-cronjob-context/tasks.md#task-1
*/
protected function setCronjobContext(string $jobId): bool
{
Expand Down Expand Up @@ -183,6 +184,7 @@ protected function setCronjobContext(string $jobId): bool
* @param string $jobId The identifier of the cronjob
*
* @return void
* @spec openspec/changes/retrofit-2026-05-26-cronjob-context/tasks.md#task-1
*/
protected function clearCronjobContext(string $jobId): void
{
Expand Down
1 change: 1 addition & 0 deletions lib/BackgroundJob/OrganizationContactSyncJob.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ public function __construct(
* @return void
*
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @spec openspec/changes/retrofit-2026-05-26-cronjob-context/tasks.md#task-2
*/
protected function run($argument): void
{
Expand Down
8 changes: 8 additions & 0 deletions lib/Controller/AangebodenGebruikController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ public function __construct(
* @NoCSRFRequired
* @PublicPage
* @PublicPage
* @spec openspec/changes/retrofit-2026-05-26-aangeboden-gebruik-api/tasks.md#task-1
*/
public function getGebruiksWhereAfnemer(): JSONResponse
{
Expand Down Expand Up @@ -160,6 +161,7 @@ public function getGebruiksWhereAfnemer(): JSONResponse
* @NoAdminRequired
* @NoCSRFRequired
* @PublicPage
* @spec openspec/changes/retrofit-2026-05-26-aangeboden-gebruik-api/tasks.md#task-1
*/
public function getKoppelingenGebruikByUuid(string $uuid): JSONResponse
{
Expand Down Expand Up @@ -250,6 +252,7 @@ public function getKoppelingenGebruikByUuid(string $uuid): JSONResponse
* @NoAdminRequired
* @NoCSRFRequired
* @PublicPage
* @spec openspec/changes/retrofit-2026-05-26-aangeboden-gebruik-api/tasks.md#task-1
*/
public function getAllGebruiksForAmbtenaar(): JSONResponse
{
Expand Down Expand Up @@ -357,6 +360,7 @@ public function getAllGebruiksForAmbtenaar(): JSONResponse
* @PublicPage
*
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @spec openspec/changes/retrofit-2026-05-26-aangeboden-gebruik-api/tasks.md#task-1
*/
public function getSingleGebruikForAmbtenaar(string $gebruikId): JSONResponse
{
Expand Down Expand Up @@ -529,6 +533,7 @@ private function isUserInGroup(string $groupName): bool
* @NoCSRFRequired
* @PublicPage
* @PublicPage
* @spec openspec/changes/retrofit-2026-05-26-aangeboden-gebruik-api/tasks.md#task-1
*/
public function getGebruiksWhereDeelnemers(): JSONResponse
{
Expand Down Expand Up @@ -607,6 +612,7 @@ public function getGebruiksWhereDeelnemers(): JSONResponse
* @NoCSRFRequired
* @PublicPage
* @PublicPage
* @spec openspec/changes/retrofit-2026-05-26-aangeboden-gebruik-api/tasks.md#task-2
*/
public function setGebruikSelfToActiveOrg(string $gebruikId): JSONResponse
{
Expand Down Expand Up @@ -714,6 +720,7 @@ function ($key) {
* @NoCSRFRequired
* @PublicPage
* @PublicPage
* @spec openspec/changes/retrofit-2026-05-26-aangeboden-gebruik-api/tasks.md#task-2
*/
public function deleteGebruikAsAfnemer(string $gebruikId): JSONResponse
{
Expand Down Expand Up @@ -814,6 +821,7 @@ function ($key) {
* @PublicPage
*
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @spec openspec/changes/retrofit-2026-05-26-aangeboden-gebruik-api/tasks.md#task-3
*/
public function getApiDocumentation(): JSONResponse
{
Expand Down
12 changes: 12 additions & 0 deletions lib/Controller/ContactpersonenController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,7 @@ public function __construct(
*
* @NoAdminRequired
* @NoCSRFRequired
* @spec openspec/changes/retrofit-2026-05-26-contactpersonen-api/tasks.md#task-1
*/
public function getContactpersonen(string $organisationId): JSONResponse
{
Expand Down Expand Up @@ -264,6 +265,7 @@ function ($group) {
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
* @SuppressWarnings(PHPMD.NPathComplexity)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @spec openspec/changes/retrofit-2026-05-26-contactpersonen-api/tasks.md#task-2
*/
public function convertToUser(string $contactpersoonId): JSONResponse
{
Expand Down Expand Up @@ -489,6 +491,7 @@ public function convertToUser(string $contactpersoonId): JSONResponse
*
* @NoAdminRequired
* @NoCSRFRequired
* @spec openspec/changes/retrofit-2026-05-26-contactpersonen-api/tasks.md#task-3
*/
public function changePassword(string $username, string $newPassword): JSONResponse
{
Expand Down Expand Up @@ -577,6 +580,7 @@ public function changePassword(string $username, string $newPassword): JSONRespo
*
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @spec openspec/changes/retrofit-2026-05-26-contactpersonen-api/tasks.md#task-3
*/
public function updateUserGroups(string $username, array $groups=[]): JSONResponse
{
Expand Down Expand Up @@ -700,6 +704,7 @@ function ($group) {
*
* @NoAdminRequired
* @NoCSRFRequired
* @spec openspec/changes/retrofit-2026-05-26-contactpersonen-api/tasks.md#task-1
*/
public function getContactPersonsWithUserDetailsForOrganization(string $organizationUuid): JSONResponse
{
Expand Down Expand Up @@ -791,6 +796,7 @@ public function getContactPersonsWithUserDetailsForOrganization(string $organiza
* @NoCSRFRequired
*
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @spec openspec/changes/retrofit-2026-05-26-contactpersonen-api/tasks.md#task-1
*/
public function getUserInfo(string $contactpersoonId): JSONResponse
{
Expand Down Expand Up @@ -917,6 +923,7 @@ public function getUserInfo(string $contactpersoonId): JSONResponse
*
* @NoAdminRequired
* @NoCSRFRequired
* @spec openspec/changes/retrofit-2026-05-26-contactpersonen-api/tasks.md#task-3
*/
public function getAvailableGroups(): JSONResponse
{
Expand Down Expand Up @@ -981,6 +988,7 @@ public function getAvailableGroups(): JSONResponse
*
* @NoAdminRequired
* @NoCSRFRequired
* @spec openspec/changes/retrofit-2026-05-26-contactpersonen-api/tasks.md#task-3
*/
public function disableUser(string $contactpersoonId): JSONResponse
{
Expand Down Expand Up @@ -1028,6 +1036,7 @@ public function disableUser(string $contactpersoonId): JSONResponse
*
* @NoAdminRequired
* @NoCSRFRequired
* @spec openspec/changes/retrofit-2026-05-26-contactpersonen-api/tasks.md#task-3
*/
public function enableUser(string $contactpersoonId): JSONResponse
{
Expand Down Expand Up @@ -1073,6 +1082,7 @@ public function enableUser(string $contactpersoonId): JSONResponse
*
* @NoAdminRequired
* @NoCSRFRequired
* @spec openspec/changes/retrofit-2026-05-26-contactpersonen-api/tasks.md#task-1
*/
public function testBulkUserInfo(): JSONResponse
{
Expand Down Expand Up @@ -1133,6 +1143,7 @@ public function testBulkUserInfo(): JSONResponse
*
* @NoAdminRequired
* @NoCSRFRequired
* @spec openspec/changes/retrofit-2026-05-26-contactpersonen-api/tasks.md#task-1
*/
public function getBulkUserInfo(): JSONResponse
{
Expand Down Expand Up @@ -1198,6 +1209,7 @@ public function getBulkUserInfo(): JSONResponse
* @NoCSRFRequired
*
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @spec openspec/changes/retrofit-2026-05-26-contactpersonen-api/tasks.md#task-1
*/
public function getMe(): JSONResponse
{
Expand Down
2 changes: 2 additions & 0 deletions lib/Controller/DashboardController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ public function __construct($appName, IRequest $request)
* @NoCSRFRequired
*
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
* @spec openspec/changes/retrofit-2026-05-26-dashboard-views-api/tasks.md#task-1
*/
public function page(?string $getParameter): TemplateResponse
{
Expand Down Expand Up @@ -75,6 +76,7 @@ public function page(?string $getParameter): TemplateResponse
* @NoCSRFRequired
*
* @return JSONResponse The JSON response with empty results
* @spec openspec/changes/retrofit-2026-05-26-dashboard-views-api/tasks.md#task-1
*/
public function index(): JSONResponse
{
Expand Down
2 changes: 2 additions & 0 deletions lib/Controller/PreferencesController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ public function __construct(
*
* @NoAdminRequired
* @NoCSRFRequired
* @spec openspec/changes/retrofit-2026-05-26-dashboard-views-api/tasks.md#task-3
*/
public function getPreference(string $key): JSONResponse
{
Expand Down Expand Up @@ -101,6 +102,7 @@ public function getPreference(string $key): JSONResponse
*
* @NoAdminRequired
* @NoCSRFRequired
* @spec openspec/changes/retrofit-2026-05-26-dashboard-views-api/tasks.md#task-3
*/
public function setPreference(string $key, string $value=''): JSONResponse
{
Expand Down
Loading
Loading