confdgnmi - restructure robot test suites - #103
Merged
Conversation
Signed-off-by: Jozef Miklos <jomiklos@cisco.com>
martin-volf
reviewed
Mar 8, 2023
| if updates is None: | ||
| return False | ||
| trace(updates) | ||
| return any(text in update.value for update in updates) |
Contributor
There was a problem hiding this comment.
I'm afraid this may not be enough - this says that e.g. "name" appears as a string in the textual representation of the latest update.
Contributor
Author
There was a problem hiding this comment.
Right, this needs to be made more strict/specific to returned data format.
I should have added TODO/notice for this "draft" implementation.
Will fix before merge...
Signed-off-by: Jozef Miklos <jomiklos@cisco.com>
Signed-off-by: Jozef Miklos <jomiklos@cisco.com>
micnovak
reviewed
Mar 9, 2023
|
|
||
| Supported encodings should have some JSON | ||
| @{encodings}= List supported encodings | ||
| Should contain ${encodings} JSON_IETF |
Contributor
There was a problem hiding this comment.
Is JSON_IETF mandatory in our tests? And why?
Contributor
Author
There was a problem hiding this comment.
good question 😉 @martin-volf - as initial author of this test case can chime in?
Contributor
There was a problem hiding this comment.
Because that is the only encoding that really makes sense. All other ones are underspecified and device specific.
Contributor
There was a problem hiding this comment.
can we be sure gNMI devices behave this way?
https://doc.gambitcom.com/mimic/gnmi.htm
e.g. this simulator claims JSON is mandatory (only?)
| Basic functionality of the Subscribe POLL RPC . | ||
| # Parameters: common connection parameters, path, poll count, poll interval. | ||
| # Failure: Device does not respond, responds with an error, responds with an empty notification set or with a notification without updates, responds with incorrect encoding. | ||
| # Test is passed path to the data model, which contains limited number of elements. Subscription operation is invoked. First SubscriptionRequest is ONCE. After that POLL subscription requests are invoked with poll interval delay. Test verifies for each subscription data is received. Optionally, it can verify the data is the same as the one received in response for ONCE subscription. Test issues WARNING, if SubscriptionResponse stream is closed prematurely. Test issues WARNING if Updates in SubscriptionResponse are aggregated. |
Contributor
There was a problem hiding this comment.
Not fully correct wording. Should be First SubscriptionRequest is similar to ONCE, with POLL mode in the SubscriptionList, After that POLL SubscriptionRequests messages are ... - my error in initial text.
| Subscribe POLL RPC with updates_only in the SubscriptionList. | ||
| # Parameters: common connection parameters, path, poll count, poll interval. | ||
| # Failure: Device does not respond, responds with an error, responds with an empty notification set or with a notification without updates, responds with incorrect encoding. | ||
| # Test is passed path to the data model, which contains limited number of elements. Subscription` operation is invoked. First SubscriptionRequest is ONCE with filled SubscriptionList containing updates_only set to true. This subscription is handled as ONCE subscription. After that, empty POLL subscription requests are invoked with poll interval delay. Test verifies for each subscription (also for initial ONCE) a SubscriptionResponse is received with only sync_response set to true (without other fields). Test issues WARNING, if SubscriptionResponse stream is closed prematurely. Test issues WARNING if Updates in SubscriptionResponse are aggregated. |
Contributor
There was a problem hiding this comment.
Same incorrect wording as previous
| Basic functionality of the Subscribe STREAM RPC with ON_CHANGE mode. | ||
| # Parameters: common connection parameters, path, read count | ||
| # Failure: Device does not respond, responds with an error, responds with an empty notification set or with a notification without updates, responds with incorrect encoding. | ||
| # Test is passed path to the data model, which contains limited number of elements, where some of them periodically change (e.g. packet count on interface). STREAM` Subscription operation is invoked. First SubscriptionResponse contains all elements, next responses contains only changed elements. After read count parameter test ends (and subscription stream is closed). Test issues WARNING, if SubscriptionResponse stream is closed prematurely. Test issues WARNING if Updates in SubscriptionResponse are aggregated. |
Contributor
There was a problem hiding this comment.
Maybe first implementation should end with error instead of WARNING as this is error.
| Subscribe for not existing prefix | ||
|
|
||
| We will not test TARGET_DEFINED mode | ||
| # TODO - why? |
Signed-off-by: Jozef Miklos <jomiklos@cisco.com>
Signed-off-by: Jozef Miklos <jomiklos@cisco.com>
Merged
Signed-off-by: Jozef Miklos <jomiklos@cisco.com>
Signed-off-by: Jozef Miklos <jomiklos@cisco.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.