If cache directory doesn't exist, create it.#135
Merged
Conversation
|
This PR seems to change all kinds of things unrelated to creating directories? |
Contributor
Author
|
Oh, I didn't realize it would add more changes I did to my fork. It should only be the first commit in this PR. |
Contributor
|
Yep, PRs track branches. This is why it's best to create a separate branch to hold your changes, and then make the PR off of that branch. |
Contributor
Author
|
Sorry about that. I think this is the second time I've ever done a PR. I've gone and reverted back to the proper PR. |
|
Looks good to me now. |
Closed
shadoath
approved these changes
Aug 3, 2020
Collaborator
|
@richrd Mergeable? |
richrd
approved these changes
Sep 3, 2020
Collaborator
|
@richrd I have asked to help maintain this project. Looking forward to moving some of these PR forward and closing some of the issues related to them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been using this plugin and over the past couple of updates the cache directory seems to just vanish. There should be a check to see if the cache directory exists before warning that the permissions are incorrect.