Added function_exists( 'compiler' ) check for function compiler()#142
Closed
MaxwellGarceau wants to merge 1 commit into
Closed
Added function_exists( 'compiler' ) check for function compiler()#142MaxwellGarceau wants to merge 1 commit into
MaxwellGarceau wants to merge 1 commit into
Conversation
I wrote code that hooks into WP-SCSS from the child theme and causes both the parent and child theme to compile. I was getting a "cannot redeclare function compiler()" error. I wrapped function compiler() with a function_exists( 'compiler' ) check and that solved the problem. Would you mind putting this in the next release? Love the plugin by the way <3.
Collaborator
|
@MaxwellGarceau please indent the code inside of the new function_exists check. I'll be happy to merge it in after that. |
Collaborator
|
@MaxwellGarceau Also would it make sense to add an else block with an error message if |
Collaborator
|
Fixed in #155 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wrote code that hooks into WP-SCSS from the child theme and causes both the parent and child theme to compile. I was getting a "cannot redeclare function compiler()" error.
I wrapped function compiler() with a function_exists( 'compiler' ) check and that solved the problem. Would you mind putting this in the next release?
Love the plugin by the way <3.