Skip to content

Enqueue css with URL. #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shadoath merged 5 commits into from
Mar 12, 2021
Merged

Enqueue css with URL. #175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fdc1434
Enqueue needs URL not path
Mar 5, 2021
ccd9cfb
Testing encoded URI
Mar 5, 2021
6534f31
Windows enqueue path/url fix
mmcev106 Mar 11, 2021
1d7aafa
Merge pull request #179 from mmcev106/enqueue-url-not-path
shadoath Mar 12, 2021
6a88391
Version bump
Mar 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions class/class-wp-scss.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,15 +211,20 @@ public function style_url_enqueued($url){
* so it can be used in a url, not path
*/
public function enqueue_files($base_folder_path, $css_folder) {
// We use realpath() to normalize any forward, backward, or trailing slack inconsistencies.
$relative_path = explode(realpath(get_home_path()), realpath($base_folder_path))[1];

// In case we're on a Windows machine
$relative_path = str_replace('\\', '/', $relative_path);

$enqueue_base_url = get_home_url() . '/' . $relative_path;

$relative_path = explode(get_home_path(), $base_folder_path)[1];
foreach( new DirectoryIterator($this->css_dir) as $stylesheet ) {
if ( pathinfo($stylesheet->getFilename(), PATHINFO_EXTENSION) == 'css' ) {
$name = $stylesheet->getBasename('.css') . '-style';
$uri = '/'.$relative_path.$css_folder.$stylesheet->getFilename();
$uri = $enqueue_base_url . $css_folder . $stylesheet->getFilename();
$ver = $stylesheet->getMTime();


wp_register_style(
$name,
$uri,
Expand Down
2 changes: 2 additions & 0 deletions readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,8 @@ Alternatively, you can include [Bourbon](https://github.com/thoughtbot/bourbon)
This plugin will only work with .scss format.

## Changelog
* 2.1.5
* Enqueue CSS files using `realpath` function. Addition by [mmcev106](https://github.com/ConnectThink/WP-SCSS/pull/179)
* 2.1.4
* Set source URL to be home_url('/') not simply `/`. Issue found by [realjjaveweb](https://github.com/ConnectThink/WP-SCSS/issues/128)
* 2.1.3
Expand Down
4 changes: 2 additions & 2 deletions wp-scss.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
* Plugin Name: WP-SCSS
* Plugin URI: https://github.com/ConnectThink/WP-SCSS
* Description: Compiles scss files live on WordPress.
* Version: 2.1.4
* Version: 2.1.5
* Author: Connect Think
* Author URI: http://connectthink.com
* License: GPLv3
Expand Down Expand Up @@ -44,7 +44,7 @@
define('WPSCSS_VERSION_KEY', 'wpscss_version');

if (!defined('WPSCSS_VERSION_NUM'))
define('WPSCSS_VERSION_NUM', '2.1.4');
define('WPSCSS_VERSION_NUM', '2.1.5');

// Add version to options table
if ( get_option( WPSCSS_VERSION_KEY ) !== false ) {
Expand Down