Prover: generated config samples#2566
Open
AlexandreBelling wants to merge 6 commits intoprover/dev-small-fieldsfrom
Open
Prover: generated config samples#2566AlexandreBelling wants to merge 6 commits intoprover/dev-small-fieldsfrom
AlexandreBelling wants to merge 6 commits intoprover/dev-small-fieldsfrom
Conversation
7740fe7 to
6ce4a0f
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes having the sample config-files generated from a template instead of having them manually maintained. We are always free to modify them but modification will be flags by the CI and they won't be mergeable from main.
Checklist
PR.
Note
Medium Risk
Primarily restructures and rewrites the canonical sample config files (including mainnet/staging modes and allowed-circuit bitmasks), which could affect any workflows that consume these samples. Adds a new generator invoked via
go generate, so CI/build steps that validate generated outputs may fail if the generator/template diverge.Overview
Sample prover configs are now generated. Adds
config_sample_generator(template + Go program) and wires it intoprover/config/config.govia//go:generateto produce the committedconfig-*.tomlfiles.Regenerates/normalizes the sample configs for
devnet,e2e,sepolia, andmainnet(version bump to6.1.5, removes machine-specific paths, standardizes controller/requests settings, and updatesprover_mode/is_allowed_circuit_id/verifier_idvalues), adds aprover/config/.gitignoreto ignore non-sample.tomlfiles, and removesconfig-integration-benchmark.toml.Written by Cursor Bugbot for commit ee8597b. This will update automatically on new commits. Configure here.