ProofAggregationCoordinatorService: remove dependency on AggregationsRepository and ForcedTransactionsDao#2590
Merged
gauravahuja merged 2 commits intomainfrom Mar 20, 2026
Conversation
.../net/consensys/zkevm/ethereum/coordination/aggregation/ProofAggregationCoordinatorService.kt
Show resolved
Hide resolved
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2590 +/- ##
============================================
+ Coverage 9.70% 58.70% +48.99%
- Complexity 0 1611 +1611
============================================
Files 454 456 +2
Lines 18530 18541 +11
Branches 2014 2016 +2
============================================
+ Hits 1799 10884 +9085
+ Misses 16731 6989 -9742
- Partials 0 668 +668
*This pull request uses carry forward flags. Click here to find out more.
🚀 New features to boost your workflow:
|
d436dd3 to
1a647a1
Compare
coordinator/app/src/main/kotlin/net/consensys/zkevm/coordinator/app/conflation/ConflationApp.kt
Outdated
Show resolved
Hide resolved
coordinator/app/src/main/kotlin/net/consensys/zkevm/coordinator/app/conflation/ConflationApp.kt
Outdated
Show resolved
Hide resolved
1a647a1 to
aee2178
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
coordinator/app/src/main/kotlin/net/consensys/zkevm/coordinator/app/conflation/ConflationApp.kt
Outdated
Show resolved
Hide resolved
…dependency on AggregationsRepository and ForcedTransactionsDao
aee2178 to
bf1e1a7
Compare
Collaborator
fluentcrafter
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Part 1 of #2241
This PR implements issue(s) #2241
Checklist
PR.
Note
Medium Risk
Medium risk because it changes how proven aggregations are persisted and how invalidity proofs are fetched by introducing new injected handlers/providers; incorrect wiring could break aggregation finalization or metrics updates.
Overview
Refactors
ProofAggregationCoordinatorServiceto remove direct dependencies onAggregationsRepositoryandForcedTransactionsDaoby introducing injected abstractions:AggregationProofHandler(persists proven aggregations and updates highest/consecutive aggregation trackers) andInvalidityProofProvider(supplies invalidity proof indexes).Updates
ConflationAppwiring to construct and passAggregationProofHandlerImpl,InvalidityProofProviderImpl, and an externally-createdAggregationL2StateProviderImpl(and reuses a singlel2MessageServiceinstance). Tests are adjusted to mock the new interfaces and validate the aggregation flow with the new injection points.Written by Cursor Bugbot for commit d87df61. This will update automatically on new commits. Configure here.