[ZkTracer] feat: split AddressCollisionDelegationWarmingAndDeploymentTests per d…#2598
[ZkTracer] feat: split AddressCollisionDelegationWarmingAndDeploymentTests per d…#2598
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2598 +/- ##
=====================================
Coverage 9.70% 9.70%
=====================================
Files 454 453 -1
Lines 18530 18528 -2
Branches 2014 2014
=====================================
Hits 1799 1799
+ Misses 16731 16729 -2
*This pull request uses carry forward flags. Click here to find out more. 🚀 New features to boost your workflow:
|
| } | ||
|
|
||
| return arguments.stream(); | ||
| } |
There was a problem hiding this comment.
I believe the input function is invoked for each of the tests below (you can check with debugging), while we could compute it only once, store it in the class and feed it to each test.
letypequividelespoubelles
left a comment
There was a problem hiding this comment.
You just splitted the test in 5 different tests to not have a single test timeout right ? I'm wondering if it's not better to just do a sampling of the test ...
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
| isDeployment == 1, | ||
| warming1, | ||
| warming2, | ||
| warming3)); |
There was a problem hiding this comment.
Redundant inputs() computation across six test methods
Low Severity
The inputs() static method is now used as @MethodSource by six separate test methods, causing it to be invoked six times — each time recomputing the identical combinatorial Stream<Arguments>. Previously, the delegation type was part of inputs(), so it was called once. As the reviewer @lorenzogentile404 noted, the result could be computed once and stored in a static field, then referenced by each test method.


…elegation type
This PR implements issue(s) #
Checklist
PR.
Note
Low Risk
Test-only refactor that changes how parameterized cases are generated/executed; primary risk is increased runtime or altered coverage if the new method split misconfigures parameters.
Overview
Refactors
AddressCollisionDelegationWarmingAndDeploymentTestsso delegation type is no longer part of the@MethodSourceparameter set, and instead the suite is split into multiple@ParameterizedTestmethods that each run the same input matrix with a fixedAccountDelegationType.This keeps the underlying
runWithParameters(...)logic the same while changing test enumeration/structure (and likely increasing the number of executed test cases via separate test methods per delegation type).Written by Cursor Bugbot for commit 8fb92b7. This will update automatically on new commits. Configure here.