Skip to content

[Coordinator] Local setup for testing conflation backtesting#2626

Open
gauravahuja wants to merge 1 commit intomainfrom
gauravahuja/setup_conflation_backtesting
Open

[Coordinator] Local setup for testing conflation backtesting#2626
gauravahuja wants to merge 1 commit intomainfrom
gauravahuja/setup_conflation_backtesting

Conversation

@gauravahuja
Copy link
Contributor

@gauravahuja gauravahuja commented Mar 20, 2026

This PR implements issue(s) #2240

Checklist

  • I wrote new tests for my new core changes.
  • I have successfully ran tests, style checker and build against my new changes locally.
  • If this change is deployed to any environment (including Devnet), E2E test coverage exists or is included in this
    PR.
  • I have informed the team of any breaking changes if there are any.

Note

Low Risk
Low risk: primarily local config/docker wiring and documentation updates; runtime behavior change is limited to exposing the coordinator JSON-RPC port and adjusting backtesting app trace client config.

Overview
Adds local environment support for conflation backtesting by introducing a dedicated conflation-backtesting-traces-node Besu service (with its own config and log4j) and wiring it into compose-tracing-v2.yml.

Updates coordinator local config to set conflation.backtesting-directory and expose the JSON-RPC API on 9546, with Docker port mapping added accordingly.

Adjusts ConflationBacktestingApp to use only traces.common for the backtesting endpoint (explicitly disabling traces.counters/traces.conflation overrides), and expands docs/features/coordinator.md with end-to-end usage instructions for conflation_createProverRequests and conflation_getReconflationJobsStatus.

Written by Cursor Bugbot for commit 64f5e28. This will update automatically on new commits. Configure here.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

requestLimitPerEndpoint = conflationBacktestingAppConfig.tracesApi.requestLimitPerEndpoint,
),
counters = null,
conflation = null,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Null counters/conflation may break trace endpoint resolution

Medium Severity

Setting counters and conflation to null instead of copying them with the backtesting endpoint may cause issues if downstream code expects these to be non-null. The previous code explicitly configured both with the backtesting traces API endpoint and request limit — now they rely on an implicit fallback to common. If the trace client resolution logic doesn't fall back to common when counters or conflation is null, the backtesting app will fail when requesting trace counts or generating conflated traces.

Fix in Cursor Fix in Web

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If common is set, counters and conflation have to be null.

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.91%. Comparing base (76de532) to head (64f5e28).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
.../conflationbacktesting/ConflationBacktestingApp.kt 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2626      +/-   ##
============================================
+ Coverage     58.89%   58.91%   +0.01%     
- Complexity     1620     1621       +1     
============================================
  Files           454      454              
  Lines         18530    18526       -4     
  Branches       2014     2012       -2     
============================================
+ Hits          10913    10914       +1     
+ Misses         6948     6944       -4     
+ Partials        669      668       -1     
Flag Coverage Δ *Carryforward flag
hardhat 96.53% <ø> (ø) Carriedforward from 76de532
kotlin 54.75% <0.00%> (+0.01%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
.../conflationbacktesting/ConflationBacktestingApp.kt 10.13% <0.00%> (+0.17%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants