[Coordinator] Local setup for testing conflation backtesting#2626
[Coordinator] Local setup for testing conflation backtesting#2626gauravahuja wants to merge 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
| requestLimitPerEndpoint = conflationBacktestingAppConfig.tracesApi.requestLimitPerEndpoint, | ||
| ), | ||
| counters = null, | ||
| conflation = null, |
There was a problem hiding this comment.
Null counters/conflation may break trace endpoint resolution
Medium Severity
Setting counters and conflation to null instead of copying them with the backtesting endpoint may cause issues if downstream code expects these to be non-null. The previous code explicitly configured both with the backtesting traces API endpoint and request limit — now they rely on an implicit fallback to common. If the trace client resolution logic doesn't fall back to common when counters or conflation is null, the backtesting app will fail when requesting trace counts or generating conflated traces.
There was a problem hiding this comment.
If common is set, counters and conflation have to be null.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2626 +/- ##
============================================
+ Coverage 58.89% 58.91% +0.01%
- Complexity 1620 1621 +1
============================================
Files 454 454
Lines 18530 18526 -4
Branches 2014 2012 -2
============================================
+ Hits 10913 10914 +1
+ Misses 6948 6944 -4
+ Partials 669 668 -1
*This pull request uses carry forward flags. Click here to find out more.
🚀 New features to boost your workflow:
|


This PR implements issue(s) #2240
Checklist
PR.
Note
Low Risk
Low risk: primarily local config/docker wiring and documentation updates; runtime behavior change is limited to exposing the coordinator JSON-RPC port and adjusting backtesting app trace client config.
Overview
Adds local environment support for conflation backtesting by introducing a dedicated
conflation-backtesting-traces-nodeBesu service (with its own config and log4j) and wiring it intocompose-tracing-v2.yml.Updates coordinator local config to set
conflation.backtesting-directoryand expose the JSON-RPC API on9546, with Docker port mapping added accordingly.Adjusts
ConflationBacktestingAppto use onlytraces.commonfor the backtesting endpoint (explicitly disablingtraces.counters/traces.conflationoverrides), and expandsdocs/features/coordinator.mdwith end-to-end usage instructions forconflation_createProverRequestsandconflation_getReconflationJobsStatus.Written by Cursor Bugbot for commit 64f5e28. This will update automatically on new commits. Configure here.