Skip to content

chore: pin GitHub Actions to commit SHAs#3

Open
BGos87 wants to merge 1 commit into
mainfrom
chore/pin-github-actions-20260512
Open

chore: pin GitHub Actions to commit SHAs#3
BGos87 wants to merge 1 commit into
mainfrom
chore/pin-github-actions-20260512

Conversation

@BGos87
Copy link
Copy Markdown

@BGos87 BGos87 commented May 12, 2026

Summary

Pin every uses: ref in .github/workflows/ (and any composite action
files) to a full 40-character commit SHA, with the original tag
preserved as a # vX comment.

Why

Tags and branches are mutable, so a compromised action can replace what
runs in our pipelines without changing the tag we reference. Pinning to
a SHA closes that supply-chain vector. See GitHub's hardening guide:
https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions#using-third-party-actions.

Deadline

TechOps is enforcing SHA-pinned GitHub Actions across the org by
June 8, 2026.
Merging this PR brings the repo into compliance ahead
of the cut-over; after that date workflows that still reference
mutable tags or branches will be blocked from running.

How

Generated mechanically with pinact run.
No version bumps were applied (strict pin); follow-up upgrades can come
from Renovate or a separate pinact run -u PR.

Test plan

  • CI green on this branch

Note

Low Risk
Low risk: this only pins existing GitHub Actions (checkout, setup-go, codecov) to immutable commit SHAs, with no changes to the test/coverage commands themselves.

Overview
Pins the Go Test & Coverage workflow’s third-party actions (actions/checkout, actions/setup-go, codecov/codecov-action) to full commit SHAs (with version comments) instead of mutable tags, hardening CI against upstream tag changes.

Reviewed by Cursor Bugbot for commit 308090d. Bugbot is set up for automated code reviews on this repo. Configure here.

Pin every `uses:` ref in .github/workflows and composite actions to a
full 40-character commit SHA, with the original tag preserved as a
comment, e.g.

    uses: actions/checkout@11bd719 # v4

Tags and branches are mutable; commit SHAs are not. Pinning to a SHA
closes a supply-chain vector where a compromised action could replace
what runs in CI without changing the tag we reference.

Generated mechanically with `pinact run`
(https://github.com/suzuki-shunsuke/pinact). No version bumps were
applied (strict pin).
gbotrel added a commit that referenced this pull request May 26, 2026
Per optim_plan_ideas.md #3 option B: the Encode path was
FFTInverse(DIF) → BitReverse → FFT(DIF) → BitReverse, where each BitReverse
on N up to 2^20 fell through gnark-crypto's threshold to `bitReverseNaive`
(~5.9% of Prove CPU).

We instead scatter the n bit-reversed inverse-FFT coefficients directly into
N bit-reversed positions (zero-padding the gaps) and run the forward FFT in
DIT order, which consumes bit-reversed input and produces normal output —
no explicit BitReverse needed.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant