Skip to content

fix: use PR base SHA for manual Strix targets - #135

Closed
seonghobae wants to merge 1 commit into
mainfrom
codex/fix-strix-manual-target-base-sha
Closed

fix: use PR base SHA for manual Strix targets#135
seonghobae wants to merge 1 commit into
mainfrom
codex/fix-strix-manual-target-base-sha

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

Summary

  • use github.event.inputs.pr_base_sha as the target workspace SHA for manual Strix PR evidence runs
  • keep github.sha only as a non-PR workflow_dispatch fallback
  • fix the shell self-test fixture so cancelled queue-state stderr is captured before assertion

Why

Manual Strix runs that target another repository must fetch a commit that exists in that target repository. The current workflow used the central .github workflow SHA during workflow_dispatch, causing upload-pack: not our ref when the target repository was aFIPC or another repo.

Validation

  • git diff --check
  • py -m pytest -q tests/test_pr_governance_audit_contract.py tests/test_opencode_review_normalize_output.py (19 passed)
  • bash scripts/ci/test_strix_quick_gate.sh after LF-normalizing CRLF checkout copies of helper shell scripts for local Windows execution (test_strix_quick_gate: PASS)

@seonghobae
seonghobae force-pushed the codex/fix-strix-manual-target-base-sha branch from 248c46a to d83a14a Compare June 29, 2026 11:48
@seonghobae

Copy link
Copy Markdown
Contributor Author

Superseded by #134. The lower-numbered PR now carries the manual target-repository Strix base-SHA fix and the central review-process fallback work, so keeping this duplicate open only adds review/check noise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant