Skip to content

Block false trivial OpenCode approval reasons #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seonghobae merged 1 commit into from
Jun 30, 2026
Merged

Block false trivial OpenCode approval reasons #233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions scripts/ci/opencode_review_normalize_output.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,9 @@

MATERIAL_CHANGE_FALSE_PHRASES = (
"change in a string is safe",
"docs-only typo",
"documentation-only typo",
"documentation string typo",
"just a string change",
"no tests are needed",
"no tests needed",
Expand All @@ -202,6 +205,8 @@
"string typo fix",
"string with no functional impact",
"string-only change",
"typo fix in documentation string",
"typo-only change",
"typo fix with no functional impact",
)

Expand Down
38 changes: 38 additions & 0 deletions tests/test_opencode_review_normalize_output.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,6 +269,44 @@ def test_material_changed_file_scope_rejects_trivial_string_approval(tmp_path, m
)


def test_material_changed_file_scope_rejects_false_documentation_typo_reason(tmp_path, monkeypatch):
changed_files = tmp_path / "changed-files.txt"
changed_files.write_text(
"\n".join(
[
".github/workflows/opencode-review.yml",
"scripts/ci/run_opencode_review_model_pool.sh",
"tests/test_opencode_agent_contract.py",
]
),
encoding="utf-8",
)
monkeypatch.setenv("OPENCODE_CHANGED_FILES_FILE", str(changed_files))

approval = control(
reason="Typo fix in documentation string",
summary=FULL_SUMMARY.replace(
"scripts/ci/example.py",
"scripts/ci/run_opencode_review_model_pool.sh",
),
)

assert norm.contradicts_material_changed_file_scope(
approval["reason"],
approval["summary"],
)
assert norm.valid_control(
approval,
expected_head_sha="head",
expected_run_id="run",
expected_run_attempt="attempt",
) is None

path = tmp_path / "approval.json"
path.write_text(json.dumps(approval), encoding="utf-8")
assert norm.check_structural_approval(path) == 4


def test_label_and_full_coverage_detection():
combined = FULL_SUMMARY.casefold()
assert "100%" in norm.label_section(combined, "coverage:")
Expand Down
Loading