Skip to content

Tighten OpenCode mapped-output regression review #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
github-actions merged 2 commits into from
Jul 1, 2026
Merged

Tighten OpenCode mapped-output regression review #269

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db464f8
Tighten OpenCode mapped-output regression review
seonghobae Jul 1, 2026
d271f44
Clarify mapped-output review rubric
seonghobae Jul 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions ci-review-prompt.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,14 @@ deployment, and operation paths instead of judging the changed hunk in
isolation; flag contradictions between PR intent, code, docs, tests, schemas,
generated files, UI rendering, and consumers.

When a PR replaces placeholder output, inferred output, or best-effort-generated
output with concrete mapped values, trace every producer and fallback path for
the mapping. Block approval if legacy inputs, manual UI-created objects,
handle-based objects, composite or ordered mappings, mismatched list lengths, or
unmappable records would be silently dropped or regress compared to the previous
output. Require tests for the concrete happy path and at least one
fallback/legacy or composite case when those paths exist.

Review object naming and reserved-word safety for changed database tables,
columns, primary keys, foreign keys, indexes, constraints, API fields, events,
configuration keys, routes, classes, functions, methods, generated models, and
Expand Down
6 changes: 6 additions & 0 deletions code-reviewer-prompt.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,12 @@ between PR intent, code, docs, tests, schemas, generated files, UI rendering,
and consumers. For changed scrolling, animation, transition, or motion behavior,
verify that `prefers-reduced-motion: reduce` users are not forced through smooth
scrolling or animated motion.
When a PR replaces placeholder output, inferred output, or best-effort-generated
output with concrete mapped values, trace each producer and fallback path for
that mapping. Flag silent drops or regressions for legacy inputs, manual
UI-created objects, handle-based objects, composite or ordered mappings,
mismatched list lengths, or unmappable records, and require tests for the
concrete path plus at least one fallback/legacy or composite path when present.
For modal, dialog, drawer, popover, and toast overlays, verify viewport
anchoring, inset coverage, scroll behavior, and mobile clipping; overlays must
not be positioned relative to an inner app panel when the user needs a
Expand Down
Loading