-
Notifications
You must be signed in to change notification settings - Fork 0
⚡ Bolt: [성능 개선] 자격 증명 마스킹 시 문자열 일괄 추가 사용 #652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
문자열 누적 최적화의 복잡도 설명을 일관되게 수정해 주세요.
Python 리스트의
append는 분할상환 O(1)이고 최종join은 O(N)이므로, 기존 방식도 점근적으로 O(N)입니다. 이번 변경의 효과는 O(N²)에서 O(N)으로의 변환이 아니라, 비매칭 구간을 묶어 append 호출과 리스트 항목 수를 줄이는 것입니다.scripts/ci/redact_sensitive_log.py#L109-L110: 인라인 주석을 실제 상수 계수 개선으로 수정해 주세요..jules/bolt.md#L46-L48: 최적화 지침에서 O(N²) 메모리·실행 시간 주장을 제거해 주세요.📍 Affects 2 files
scripts/ci/redact_sensitive_log.py#L109-L110(this comment).jules/bolt.md#L46-L48🤖 Prompt for AI Agents