-
Notifications
You must be signed in to change notification settings - Fork 0
feat(review): add keyless OmniRoute free-gateway provider to the OpenCode review pool #675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
seonghobae
wants to merge
2
commits into
main
from
claude/contextualwisdomlab-audit-governance-fb7470
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -796,6 +796,44 @@ def test_free_provider_runtime_cap_preserves_queue_budget(tmp_path: Path) -> Non | |
| ) in result.stdout | ||
|
|
||
|
|
||
| def test_omniroute_candidate_requires_base_url(tmp_path: Path) -> None: | ||
| """The keyless OmniRoute gateway is skipped when its base URL is not configured.""" | ||
| result = run_failed_model( | ||
| tmp_path, | ||
| model_candidates="omniroute/combo", | ||
| extra_env={"OMNIROUTE_API_BASE_URL": ""}, | ||
| ) | ||
|
|
||
| assert result.returncode == 1 | ||
| assert ( | ||
| "Skipping OpenCode omniroute/combo because OMNIROUTE_API_BASE_URL is not " | ||
| "configured; falling back to the next provider-qualified candidate." | ||
| ) in result.stdout | ||
| assert ( | ||
| "OpenCode model pool exhausted before producing a valid control conclusion." | ||
| in result.stdout | ||
| ) | ||
|
|
||
|
|
||
| def test_omniroute_runtime_cap_preserves_queue_budget(tmp_path: Path) -> None: | ||
| """A stalled keyless OmniRoute gateway cannot consume a full paid-provider slot.""" | ||
| result = run_failed_model( | ||
| tmp_path, | ||
| extra_env={ | ||
| "OMNIROUTE_API_BASE_URL": "https://omniroute.example/v1", | ||
| "OPENCODE_FREE_RUN_TIMEOUT_SECONDS": "3", | ||
| "OPENCODE_RUN_TIMEOUT_SECONDS": "9", | ||
| }, | ||
| model_candidates="omniroute/combo", | ||
| ) | ||
|
|
||
| assert result.returncode == 1 | ||
| assert ( | ||
| "OpenCode omniroute/combo runtime cap selected 3s " | ||
| "instead of 9s because this provider has a bounded failover window." | ||
| ) in result.stdout | ||
|
Comment on lines
+818
to
+834
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win 실제 타임아웃을 발생시키세요. 이 테스트는 가짜 제공자를 3초보다 길게 대기시키세요. 3초 타임아웃 결과와 다음 후보로의 진행을 확인하세요. 🤖 Prompt for AI Agents |
||
|
|
||
|
|
||
| def test_github_models_openai_prompt_references_evidence_without_inlining( | ||
| tmp_path: Path, | ||
| ) -> None: | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
다음 후보 실행을 검증하세요.
현재 후보 목록에는
omniroute/combo만 있습니다. 따라서 러너가 건너뛴 후 즉시 종료해도 이 테스트는 통과합니다.omniroute/combo뒤에 실행 가능한 후보를 추가하세요. 그 후보의 시도가 로그에 기록되는지 확인하세요.🤖 Prompt for AI Agents