fix(coverage): preserve LLVM 19 across isolated Rust evidence - #816
fix(coverage): preserve LLVM 19 across isolated Rust evidence#816seonghobae wants to merge 5 commits into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
@opencode-agent Implement the GREEN production repair for this PR on the exact current branch. Keep the existing RED contract unchanged. In |
|
/oc Refetch the exact live PR head and abort unless it is |
|
@opencode-agent Implement the current exact-head RED contract directly on this PR branch; do not open a stacked PR and do not create any one-shot, self-modifying, encoded-patch, staged-patch, repair-* or branch-writer workflow. Live head when requested: Apply the minimum authoritative-source repair in
Run the focused permanent contract first, then the complete repository quality/security suite. Keep the PR Draft until a new exact head is GREEN. Commit only the direct production/test/documentation changes on this branch. |
|
Operate on the exact live PR head only. Refetch PR #816 and abort unless the head is In
Preserve the image digest, cargo-llvm-cov URL/SHA-256, exact-head materialization, |
|
@opencode-agent address Implement the existing RED contract directly on exact head Modify only the canonical
Run the permanent focused contract and full exact-head suite. Keep Draft until the canonical implementation is GREEN and every new-head check/review gate reruns. |
|
@opencode-agent Implement the exact-current-head GREEN repair on PR #816 without creating any new repair workflow or weakening protections. Starting from current head |
|
@coderabbitai review |
|
@opencode-agent Implement the permanent GREEN fix directly on exact Draft head The authoritative failing contract requires one reviewed LLVM 19 chain in
Keep Draft and do not approve, merge, release, alter reviewer credentials, or weaken branch protection. |
|
|
@coderabbitai autofix Apply the permanent RED→GREEN LLVM runtime-boundary repair directly to exact head In
Run |
|
Autofix skipped. No unresolved CodeRabbit review comments with fix instructions found. |
|
@coderabbitai autofix Implement the existing exact-head RED contract directly on |
|
Autofix skipped. No unresolved CodeRabbit review comments with fix instructions found. |
|
@coderabbitai Please repair |
|
/oc Refetch PR #816 and implement the RED LLVM 19 contract directly on the live branch; abort on head movement. Modify the canonical |
|
Repair exact current head |
|
/oc Refetch the live pull request and abort without writing unless its exact head is |
|
Continue the GREEN implementation directly on Apply only the remaining minimum production changes in
Run all three focused contracts, compileall, exact-range |
|
/oc Refetch live exact head
Run the three focused tests first, then the complete exact-head suite and diff checks. Do not create another partial commit, patch artifact, temporary workflow, compatibility weakening, or force-push. |
|
/oc Complete the exact-head LLVM runtime-boundary repair on The current head already provisions pinned LLVM 19 at image build time, but run
Preserve Debian Run |
|
@opencode-agent @coderabbitai autofix Continue the existing exact-head repair directly on live head Apply only these remaining production changes in
Do not alter the newly added image package/ENV/preflight, pinned cargo-llvm-cov v0.8.7 URL/SHA, image digest, exact-head source materialization, no-network/no-credential/Git isolation, native-fuzz separation, reviewer credentials, or 100% gates. Commit directly to this PR branch, do not create another PR or any one-shot/self-modifying/branch-writer workflow, and run |
|
@opencode-agent Refetch exact live head and continue only if it is |
Rate Limit Exceeded
|
|
Apply the minimum GREEN implementation directly to exact head The trusted image already installs
After branch movement, request fresh exact-head read-only OpenCode/Noema review. Do not approve, merge, release, or alter branch protection. |
|
/oc Refetch the live head and continue only if it is |
|
/oc Refetch the exact live PR head and abort unless it is |
Purpose
Restore the central OpenCode Rust coverage path required by DiskSage exact-head review without weakening fail-closed coverage, source, credential, network, or approval boundaries.
Exact current state
Current exact head:
71f74df36bbe322b1022d6eb3fa5aa7ac53d0643.Protected base
main:e71fdab2ab088001f218765ecb5e3b7fabfee11a.This head remains intentionally RED. No predecessor-head test, review, approval, or generated merge-tree evidence authorizes it.
The permanent regression contract requires:
LLVM_COV=/usr/bin/llvm-cov-19andLLVM_PROFDATA=/usr/bin/llvm-profdata-19image bindings.docker runboundary.Current implementation and RED evidence
Exact head
71f74df36bbe322b1022d6eb3fa5aa7ac53d0643now implements items 1–3 directly in the authoritative production workflow:llvm-19is installed in the existing digest-pinned trusted coverage image;ENV LLVM_COV=/usr/bin/llvm-cov-19andENV LLVM_PROFDATA=/usr/bin/llvm-profdata-19;Exact-head
OpenCode Rust Coverage Toolchain Quality CIrun31170299456, job92840404399, proves that this partial implementation is visible and also proves the remaining boundary is still absent:docker rundoes not yet receive the literal LLVM path bindings; andensure_rust_toolchaindoes not yet enforce exact-value equality and executable checks before Rust coverage.All three focused contract tests therefore fail for the intended remaining production defects. The exact-head OSV, SAST Semgrep, Security Scan, Secret Scan, Scorecard, and SBOM workflows succeeded; CodeQL and Python Security were still queued at the latest inspection and are not treated as passing.
Required GREEN implementation
Complete only the remaining minimum repair directly in
.github/workflows/opencode-review-dispatch.ymlon this branch:--env LLVM_COV=/usr/bin/llvm-cov-19and--env LLVM_PROFDATA=/usr/bin/llvm-profdata-19to the existing isolated coveragedocker runbefore the image argument;ensure_rust_toolchain, fail closed unless${LLVM_COV:-}and${LLVM_PROFDATA:-}equal those reviewed paths;test -x "$LLVM_COV"andtest -x "$LLVM_PROFDATA"before the firstcargo llvm-covinvocation;--network=none, credential isolation, Git isolation, native-fuzz separation, existing reviewer-agent credential contract, and 100% statement/branch/public-docstring gates.Do not introduce a one-shot, self-modifying, encoded-patch, staged-patch, branch-writer, or competing repair workflow. Any branch movement invalidates predecessor requests and requires fresh exact-head review.
Dependency
This is the focused central prerequisite for fresh DiskSage OpenCode coverage evidence. After protected integration, affected DiskSage PRs must rerun OpenCode coverage/review on their unchanged exact current heads. Their predecessor
REQUEST_CHANGESand failed coverage evidence remain historical only.Merge gate
Keep this PR Draft until a new GREEN exact head has successful focused and complete repository quality/security evidence, no unresolved actionable human or automated finding, a qualifying independent non-author approval, and branch-protection/repository-policy acceptance without bypass. Pending, queued, cancelled, skipped-required, neutral-required, absent, stale-head, status-only, or predecessor-head evidence is not passing.