feat(opencode): add risk-adaptive shadow review pool - #839
Draft
seonghobae wants to merge 1 commit into
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Implement the production-independent part of Task 6 in the OpenCode review-quality plan: risk-adaptive detector routing, bounded OpenCode shadow execution, and independent source-contract verification without GitHub publication authority.
Exact stacked identity
feat/opencode-review-decision-envelope(PR feat(opencode): separate semantic and merge decisions #836);c3133887df775605bfca2aaaa8b94094aec609fc;feat/opencode-review-shadow-pool;4fc5d75fe01258bbc469373eafdcc2d8afb55cfa;No check, review, approval, or comment from PR #829, #831, or #836 authorizes this stacked head. If a predecessor moves or integrates, this branch must be reconciled once and every exact-head evidence surface regenerated.
Permanent test-first contract
The current head contains only permanent tests and an exact-head quality workflow. The production planner, executor, verifier, and shell wrapper intentionally do not exist yet, so the first quality run must fail during collection.
The tests require:
--agent,--model,--variant,--format json, exact evidence files, and bounded per-attempt timeout;NVIDIA_NIM_API_KEYmapped only to the childNVIDIA_API_KEYwithout logging or argument exposure;shadow_findingsonly, withpublished_findings=[]and publication disabled;Production and writer boundary
This PR must not edit
.github/workflows/opencode-review-dispatch.yml,opencode.jsonc, reviewer identities, model credentials, or GitHub publication code. Active central branches still own the dispatch workflow. The shadow runner produces raw attempt artifacts and the verifier produces a non-publishing report only.A later protected integration slice may wire the proven pool and decision envelope into the dispatch after the writer lease clears and must begin with a separate failing production contract.
Safety and acceptance
COPILOT_GITHUB_TOKENuse;Keep Draft and do not merge until all stacked predecessors integrate, this branch is reconciled onto the exact protected base, all exact-head quality/security/review evidence passes, no valid unresolved finding remains, and a qualifying independent non-author formal approval exists.