Skip to content

๐Ÿงช redact_sensitive_log ํ…Œ์ŠคํŠธ ์ถ”๊ฐ€ - #845

Closed
seonghobae wants to merge 1 commit into
mainfrom
test-redact-sensitive-log-137040798574166017
Closed

๐Ÿงช redact_sensitive_log ํ…Œ์ŠคํŠธ ์ถ”๊ฐ€#845
seonghobae wants to merge 1 commit into
mainfrom
test-redact-sensitive-log-137040798574166017

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

๐ŸŽฏ What:
scripts/ci/redact_sensitive_log.py ์Šคํฌ๋ฆฝํŠธ์— ๋Œ€ํ•œ ๋‹จ์œ„ ํ…Œ์ŠคํŠธ๊ฐ€ ๋ˆ„๋ฝ๋˜์–ด ์žˆ์–ด ์ด๋ฅผ ๋ณด์™„ํ•˜๊ธฐ ์œ„ํ•ด 100% ํ…Œ์ŠคํŠธ ์ปค๋ฒ„๋ฆฌ์ง€๋ฅผ ์ œ๊ณตํ•˜๋Š” ํ…Œ์ŠคํŠธ ์Šค์œ„ํŠธ๋ฅผ ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค.

๐Ÿ“Š Coverage:

  • ๋นˆ ๋ฌธ์ž์—ด ๋ฐ None ์ž…๋ ฅ์— ๋Œ€ํ•œ ์ฒ˜๋ฆฌ
  • ์ค„๋ฐ”๊ฟˆ ๋ฌธ์ž์—ด(\n, \r\n)์˜ ๋ณด์กด ํ™•์ธ
  • ์œ ํšจํ•œ JSON ๋ฌธ์ž์—ด ๋‚ด์˜ ์žฌ๊ท€์  ๋งˆ์Šคํ‚น ์ฒ˜๋ฆฌ ํ™•์ธ
  • ๋น„์ •ํ˜• ํ…์ŠคํŠธ ๋‚ด์˜ ํ† ํฐ ํŒจํ„ด(GH ํ† ํฐ, AWS ํ‚ค ๋“ฑ) ๋งˆ์Šคํ‚น ์ฒ˜๋ฆฌ ํ™•์ธ
  • ์„ ํ˜• ํƒ์ƒ‰์„ ํ†ตํ•œ ํ‚ค-๊ฐ’ ํ• ๋‹น(key=value, key: value) ๋งˆ์Šคํ‚น ์ฒ˜๋ฆฌ
  • ํ† ํฐ ํŒŒ์‹ฑ ์—์ง€ ์ผ€์ด์Šค ๋ฐ ๋นˆ ๊ฐ’ ์ฒ˜๋ฆฌ
  • JWT ๋ฐ Bearer ํ† ํฐ ๋ฌธ์ž์—ด ๋งˆ์Šคํ‚น ํ™•์ธ
  • ์Šคํฌ๋ฆฝํŠธ ๋ฉ”์ธ ์ง„์ž…์  ๋ฐ SystemExit ์ฒ˜๋ฆฌ ์‹œ๋‚˜๋ฆฌ์˜ค ํ™•์ธ

โœจ Result:
redact_sensitive_log.py์˜ ๋ชจ๋“  ๋ถ„๊ธฐ ๋กœ์ง๊ณผ ์—์ง€ ์ผ€์ด์Šค์— ๋Œ€ํ•ด 100% ์ฝ”๋“œ ์ปค๋ฒ„๋ฆฌ์ง€๊ฐ€ ๋‹ฌ์„ฑ๋˜์–ด ๋ฆฌํŒฉํ† ๋ง ์‹œ ์•ˆ์ „์„ฑ์ด ํ™•๋ณด๋˜์—ˆ์Šต๋‹ˆ๋‹ค. ๋˜ํ•œ mypy, bandit, interrogate ๋“ฑ์˜ ์ •์  ๋ถ„์„ ๋„๊ตฌ ๊ฒ€์ฆ์„ ์™„๋ฃŒํ•˜์˜€์Šต๋‹ˆ๋‹ค.


PR created automatically by Jules for task 137040798574166017 started by @seonghobae

@google-labs-jules

Copy link
Copy Markdown

๐Ÿ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a ๐Ÿ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Aug 9, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 59 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
โš™๏ธ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 0dc10e4f-9d1e-4fd6-8865-859644a4f5fd

๐Ÿ“ฅ Commits

Reviewing files that changed from the base of the PR and between 6eb06cd and 029a587.

๐Ÿ“’ Files selected for processing (2)
  • .Jules/palette.md
  • tests/test_redact_sensitive_log.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

โค๏ธ Share

Comment @coderabbitai help to get the list of available commands.


def test_redact_unstructured_tokens() -> None:
"""Test redacting known token patterns from unstructured text."""
text = "Here is my token: ghp_123456789012345678901234567890123456\nand another github_pat_123456789012345678901234567890\nsk-12345678901234567890\nxoxb-12345678901234567890\nAKIA1234567890ABCDEF"

Copy link
Copy Markdown
Contributor Author

RCA/feasibility: closing unmerged as superseded by the active redaction security branch #842. #842 now changes scripts/ci/redact_sensitive_log.py itself, wires it through both sandbox consumers, and owns exact-head security regressions across test_sandboxed_log_redaction_regression.py, test_sandboxed_verify.py, test_sandboxed_web_e2e.py, and OpenCode security boundaries. Its current source-tree contract reports 605 statements / 206 branches at 100% across the shared redactor and wrappers, including JSON/JWT/authorization/private-key/assignment/terminal-control/pathological-input cases. A separate current-main test-only branch for the pre-#842 redactor would immediately diverge and require reconciliation while adding no distinct uncovered production defect. Keep coverage ownership with the security branch that changes and validates the implementation.

@seonghobae seonghobae closed this Aug 9, 2026
@google-labs-jules

Copy link
Copy Markdown

RCA/feasibility: closing unmerged as superseded by the active redaction security branch #842. #842 now changes scripts/ci/redact_sensitive_log.py itself, wires it through both sandbox consumers, and owns exact-head security regressions across test_sandboxed_log_redaction_regression.py, test_sandboxed_verify.py, test_sandboxed_web_e2e.py, and OpenCode security boundaries. Its current source-tree contract reports 605 statements / 206 branches at 100% across the shared redactor and wrappers, including JSON/JWT/authorization/private-key/assignment/terminal-control/pathological-input cases. A separate current-main test-only branch for the pre-#842 redactor would immediately diverge and require reconciliation while adding no distinct uncovered production defect. Keep coverage ownership with the security branch that changes and validates the implementation.

Understood. Acknowledging that this work is now obsolete and stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants