Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .Rbuildignore
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,4 @@
^task_agent_mapping\.json$
^\.gitleaks\.toml$
^\.jules$
^\.jules/.*
^\.jules/.*$
3 changes: 3 additions & 0 deletions .jules/bolt.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
## 2024-10-24 - [Avoid Redundant MAP Estimations in aFIPC.R]
**Learning:** The `fscores()` function for MAP estimation is an expensive operation in `mirt`. In `R/aFIPC.R`, these were being calculated twice consecutively: once inline for `mirt::expected.test()` and once immediately after for assignment to output variables.
**Action:** When calculating expected scores using MAP thetas, always pre-calculate the thetas and reuse the variables rather than calling `fscores()` multiple times.
16 changes: 8 additions & 8 deletions R/aFIPC.R
Original file line number Diff line number Diff line change
Expand Up @@ -1010,28 +1010,28 @@ autoFIPC <-
# stop('Estimation failed. Please check test quality.')
# }

# calculate theta
ThetaOldform <- fscores(oldFormModel, method = 'MAP')
ThetaLinkedform <- fscores(LinkedModel, method = 'MAP')
ThetaNewform <- fscores(newFormModel, method = 'MAP')

# calculate expected score
ExpectedScoreOldform <-
mirt::expected.test(
x = oldFormModel,
Theta = fscores(oldFormModel, method = 'MAP')
Theta = ThetaOldform
)
ExpectedScoreLinkedform <-
mirt::expected.test(
x = LinkedModel,
Theta = fscores(LinkedModel, method = 'MAP')
Theta = ThetaLinkedform
)
ExpectedScoreNewform <-
mirt::expected.test(
x = newFormModel,
Theta = fscores(newFormModel, method = 'MAP')
Theta = ThetaNewform
)

# calculate theta
ThetaOldform <- fscores(oldFormModel, method = 'MAP')
ThetaLinkedform <- fscores(LinkedModel, method = 'MAP')
ThetaNewform <- fscores(newFormModel, method = 'MAP')

# save results as object
modelReturn <- new.env()
modelReturn$oldFormModel <- oldFormModel
Expand Down
Loading