⚡ Bolt: [성능 개선 및 자동화 대응] fscores 최적화 및 비대화형 프롬프트 수정 - #52
Conversation
- `fscores` 함수의 반환값을 변수에 먼저 할당한 뒤 재사용하도록 수정하여, 비용이 큰 MAP 계산을 50% 절감 - CI 환경 및 자동화 테스트 런을 위해 `!interactive()` 체크를 추가하여 대화형 프롬프트 대기로 인한 스택 오버플로우 발생 방지 - `.Rbuildignore`에 `.jules` 무시 규칙 추가 - `mirt::simdata`를 이용한 testthat 시나리오 추가
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
There was a problem hiding this comment.
Pull request overview
Optimizes autoFIPC() by eliminating redundant MAP ability-score estimation calls and hardens interactive prompts so CI/non-interactive runs won’t block on readline().
Changes:
- Pre-compute
fscores(..., method = "MAP")once per model and reuse forexpected.test(). - Add
!interactive()fast-paths to prompt helpers to prevent non-interactive hangs. - Add a testthat test to ensure
autoFIPC()completes in non-interactive environments; ignore.jules/in package builds.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
R/aFIPC.R |
Avoids repeated MAP fscores() calls and adds non-interactive prompt guards. |
tests/testthat/test-package-api.R |
Adds a non-interactive execution test for autoFIPC(). |
.Rbuildignore |
Excludes .jules/ artifacts from R package builds. |
.jules/bolt.md |
Records the performance optimization note for the automation task. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…es-10831312772253420603 # Conflicts: # .Rbuildignore # .jules/bolt.md # R/aFIPC.R
OpenCode Review Overview
Pull request overviewOpenCode reviewed the current-head bounded evidence and found no blocking issues. FindingsNo blocking findings. SummaryVerification posture: CodeGraph evidence was initialized and bounded current-head evidence reviewed for changed-file evidence including .jules/bolt.md.
Change Flow DAGflowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file (3 files)"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file (3 files)"]
R1 --> V1["required checks"]
Evidence --> S2["Test: test-package-api.R"]
S2 --> I2["regression suite"]
I2 --> R2["Review risk: Test: test-package-api.R"]
R2 --> V2["targeted test run"]
|
![opencode-agent[bot]](https://avatars.githubusercontent.com/in/1549082?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
OpenCode reviewed the current-head evidence but found unresolved human review threads before approval.
Findings
1. HIGH .github/workflows/opencode-review.yml:1 - Unresolved human review thread blocks automated approval
- Problem: OpenCode reached an APPROVE control result, but the approval step found unresolved, non-outdated human review thread evidence on the current pull request.
- Root cause: Human review feedback can arrive after bounded model evidence is prepared, so the approval step must re-query GitHub immediately before publishing an approval.
- Fix: Address or resolve the listed human review thread(s), then re-run OpenCode on the current head.
- Regression test: Keep the approval gate querying reviewThreads(first: 100) after model output and before create_pull_review APPROVE.
Review thread evidence
Latest unresolved human review thread evidence
.Rbuildignore line 19
-
Latest human comment: @copilot-pull-request-reviewer at 2026-06-24T16:45:14Z
-
Comment URL: #52 (comment)
-
Comment excerpt: These two patterns are redundant. A single regex can ignore both the
.julesdirectory and everything under it, keeping.Rbuildignoresimpler. -
Result: REQUEST_CHANGES
-
Reason: unresolved human review thread(s) were present before approval.
-
Head SHA:
c7c6d6a2ab010d5c8b901500384663a2f9f8e27d -
Workflow run: 28445208914
-
Workflow attempt: 1
Change Flow DAG
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file (3 files)"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file (3 files)"]
R1 --> V1["required checks"]
Evidence --> S2["Test: test-package-api.R"]
S2 --> I2["regression suite"]
I2 --> R2["Review risk: Test: test-package-api.R"]
R2 --> V2["targeted test run"]
There was a problem hiding this comment.
Pull request overview
OpenCode reviewed the current-head bounded evidence and found no blocking issues.
Findings
No blocking findings.
Summary
Verification posture: CodeGraph evidence was initialized and bounded current-head evidence reviewed for changed-file evidence including .jules/bolt.md.
Linter/static: workflow/static review evidence is bounded by the current-head GitHub Checks gate and changed-file evidence.
TDD/regression: coverage execution evidence and focused changed hunks were reviewed from bounded-review-evidence.md.
Coverage: coverage execution evidence reports supported repository test suites passed.
Docstring coverage: coverage execution evidence reports configured repository docstring gates passed or docstring coverage was advisory.
DAG: Change Flow DAG maps .jules/bolt.md through bounded evidence, review risk, and required checks.
PoC/execution: coverage-evidence job executed on the current head and reported PASS.
DDD/domain: workflow and repository-governance invariants were reviewed against changed files in bounded evidence.
CDD/context: CodeGraph evidence, changed-file history, and focused hunks were reviewed from bounded-review-evidence.md.
Similar issues: changed-file history evidence was reviewed for comparable local precedents.
Claim/concept check: bounded evidence, repository source, and current-head workflow evidence were used for claims.
Standards search: standards and external-source checks are delegated to configured OpenCode web_search/Context7/DeepWiki sources when applicable; no evidence-backed standards blocker is present in bounded evidence.
Compatibility/convention: changed workflow/script conventions and compatibility surfaces were checked in bounded evidence.
Breaking-change/backcompat: deployment evidence and changed-file history were checked for backward-compatibility risk.
Performance: changed surfaces were checked for performance risk in bounded evidence.
Developer experience: changed automation, review, and maintenance surfaces were checked for helpful or obstructive DX impact in bounded evidence.
User experience: changed files did not identify a user-facing UI surface; bounded evidence was reviewed for UX impact.
Security/privacy: workflow-token, review-gate, and repository-automation security/privacy boundaries were checked in bounded evidence.
- Result: APPROVE
- Reason: No material issues found in the PR head source
- Head SHA:
4d7b9bfe545da80be9b4c046f1227d80bfef12e6 - Workflow run: 28445955648
- Workflow attempt: 1
Change Flow DAG
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file (3 files)"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file (3 files)"]
R1 --> V1["required checks"]
Evidence --> S2["Test: test-package-api.R"]
S2 --> I2["regression suite"]
I2 --> R2["Review risk: Test: test-package-api.R"]
R2 --> V2["targeted test run"]
* test: pin FIPC linking formulas and audit performance refactors Formula-integrity audit of the fixed item parameter calibration (FIPC) linking contract implemented by autoFIPC(). The estimation mathematics lives in mirt; this package only orchestrates the Kim (2006) contract of fixing old-form anchor parameters while non-anchor new-form parameters are estimated on the base scale. Reviewed every merged performance refactor that touches the linking path (#48/#52 fscores hoist, #51 grep->match anchor lookup, #56 category-count guard, #99 vectorized IPD anchor extraction) and confirmed each is mathematically equivalent - no term, margin, or constant changed. No formula damage found; nothing to restore. - Add tests/testthat/test-optimization-equivalence.R pinning the two formula-bearing expressions (#56 category count, #99 unlist extraction) to independent hand-computed reference values. - Strengthen test-fixed-parameter-calibration.R to assert non-anchor new-form items stay free (est == TRUE), pinning the second half of the Kim (2006) invariant. - Document the canonical linking equation, the refactor audit, and source DOIs (docs/fixed-parameter-item-calibration.md, docs/papers/README.md). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RTAMs4bpSZS77Xe3RQjv9P * docs: use item-parameter notation for FIPC contract * test: cover missing and boundary response rows --------- Co-authored-by: Seongho Bae <seonghobae@me.com> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
💡 What:
fscores(..., method = 'MAP')계산 결과를 변수에 저장 후expected.test에 전달하도록 최적화하였으며, 대화형 프롬프트에!interactive()체크를 추가했습니다.🎯 Why:
fscores를 반복 호출하는 부분은 불필요한 컴퓨팅 오버헤드를 유발하고, 비대화형 자동화 환경에서 스크립트가 무한 루프에 빠지는 문제를 해결하기 위함입니다.📊 Impact: MAP 추정 계산 비용을 50% 감소시켰으며, CI 환경에서 테스트가 정상적으로 구동됩니다.
🔬 Measurement:
Rscript test_script.R(또는testthat) 구동 시 에러 없이 빠르게 종료되는 것을 확인하고, 코드 리뷰를 통과했습니다.PR created automatically by Jules for task 10831312772253420603 started by @seonghobae