Skip to content

fix: apply BandScope desktop shell branding - #304

Merged
seonghobae merged 1 commit into
developfrom
fix/issue-206-brand-shell
Jun 15, 2026
Merged

fix: apply BandScope desktop shell branding#304
seonghobae merged 1 commit into
developfrom
fix/issue-206-brand-shell

Conversation

@seonghobae

Copy link
Copy Markdown
Collaborator

Summary

  • Adds local BandScope shell tokens and an accessible circular equalizer wordmark.
  • Updates the desktop sidebar/local-first copy toward practical rehearsal language.
  • Moves GrooveMap pitch lanes and note blocks into the dark rehearsal cockpit styling.
  • Adds tests for the accessible mark, local-first copy, and dark GrooveMap transcription surface.

Closes #206.

Verification

  • npm --workspace @bandscope/desktop run test (94 passed, 100% desktop line coverage)
  • npm --workspace @bandscope/desktop run typecheck
  • npm --workspace @bandscope/desktop run lint
  • npm --workspace @bandscope/desktop run build
  • npm run check:security-notes
  • ./scripts/harness/quickcheck.sh

Visual QA

  • Opened http://127.0.0.1:5174/ in the browser at 1440x960 and 390x844.
  • Verified the accessible BandScope circular equalizer mark, primary/compact rehearsal navigation, source controls, metric cards, and empty workspace state render without visible overlap.
  • Screenshots captured as bandscope-issue-206-desktop.png and bandscope-issue-206-mobile.png in the browser artifact output.

Security Notes

  • No file, URL, subprocess, IPC, WebView, update, model-download, or export boundary changed in this PR.
  • Brand assets are implemented as local CSS/React markup only; no remote fonts, images, screenshots, or runtime network assets were added.
  • UI continues to render filenames, project labels, and transcription metadata as React text, not HTML.
  • Test points: App shell tests pin the accessible wordmark/local-first copy; Workspace tests pin GrooveMap transcription rendering as a regular React text surface.

@coderabbitai

coderabbitai Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@seonghobae, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 29 minutes and 59 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 660e3468-e9d1-43f1-a10b-d224c4bb7bdf

📥 Commits

Reviewing files that changed from the base of the PR and between 38f2b5b and 69c53d5.

📒 Files selected for processing (5)
  • apps/desktop/src/App.test.tsx
  • apps/desktop/src/App.tsx
  • apps/desktop/src/features/workspace/GrooveMap.tsx
  • apps/desktop/src/features/workspace/Workspace.test.tsx
  • apps/desktop/src/index.css
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/issue-206-brand-shell
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch fix/issue-206-brand-shell

Warning

Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@seonghobae
seonghobae enabled auto-merge (squash) June 15, 2026 08:07
@opencode-agent

opencode-agent Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

OpenCode Review Overview

  • Head SHA: 69c53d57a7caaf619304c57e5508b8e59f465aa4
  • Workflow run: 27532641865
  • Workflow attempt: 1
  • Gate result: APPROVE (approval step)

OpenCode Agent approved this PR.

Reviewed changes in App.test.tsx and App.tsx. The changes include updated UI text and a new logo component. The text changes improve clarity about data locality. The new BandScopeMark component is accessible. The tests were updated accordingly. Other changed files were not provided in the focused hunks, but no evidence of issues was found.

  • Result: APPROVE
  • Reason: No critical issues found in the reviewed changes
  • Head SHA: 69c53d57a7caaf619304c57e5508b8e59f465aa4
  • Workflow run: 27532641865
  • Workflow attempt: 1

@opencode-agent opencode-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OpenCode Agent approved this PR.

Reviewed changes in App.test.tsx and App.tsx. The changes include updated UI text and a new logo component. The text changes improve clarity about data locality. The new BandScopeMark component is accessible. The tests were updated accordingly. Other changed files were not provided in the focused hunks, but no evidence of issues was found.

  • Result: APPROVE
  • Reason: No critical issues found in the reviewed changes
  • Head SHA: 69c53d57a7caaf619304c57e5508b8e59f465aa4
  • Workflow run: 27532641865
  • Workflow attempt: 1

@seonghobae
seonghobae merged commit dfd7916 into develop Jun 15, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Design] Apply BandScope brand story to desktop shell follow-ups

1 participant