-
Notifications
You must be signed in to change notification settings - Fork 0
๐จ Palette: ์์ด์ฝ ๋ฒํผ์ ํดํ ์ถ๊ฐ #702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
b35a971
๐จ Palette: ์์ด์ฝ ์ ์ฉ ๋ฒํผ์ ํดํ(title ์์ฑ) ์ถ๊ฐ
seonghobae 379478f
fix(deps): update yt-dlp and setuptools to fix CVEs (security-audit)
seonghobae 10a479c
fix(deps): update yt-dlp and setuptools to fix CVEs (security-audit)
seonghobae File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,6 @@ | ||
| ## 2024-05-19 - Replace HTML disabled with aria-disabled="true" for Accessible Tooltips | ||
| **Learning:** Native HTML `disabled` attributes completely hide elements from screen readers and block all pointer/hover events, preventing tooltips from functioning for disabled elements. | ||
| **Action:** Replace `disabled` with `aria-disabled="true"`, enforce block click handlers via `e.preventDefault()`, and add a title tooltip directly to the element to maintain full tooltip accessibility and keyboard focus support for visually impaired and mouse users. | ||
| ## 2025-02-27 - Icon-only button tooltips | ||
| **Learning:** Icon-only buttons (like lucide-react icons inside a `<Button>`) need a `title` attribute matching their `aria-label` to display native browser hover tooltips for mouse users, improving accessibility and discoverability. | ||
| **Action:** When adding or modifying icon-only buttons, always ensure both `aria-label` (for screen readers) and `title` (for mouse hover) are present and match. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
๐ฏ Functional Correctness | ๐ก Minor | โก Quick win
๋ค์ดํฐ๋ธ
disabled์ปจํธ๋กค์์๋ ์ถ๊ฐํ ํดํ์ด ๋์ํ์ง ์์ต๋๋ค.๋ค์ ์์น๋ค์
title์ ์ถ๊ฐํ์ง๋ง ์ธ์ ํdisabled์กฐ๊ฑด์ด ํธ๋ฒ ์ด๋ฒคํธ๋ฅผ ์ฐจ๋จํฉ๋๋ค. ์์ด์ฝ ๋ฒํผ์ ํดํ๊ณผ ํค๋ณด๋ ์ ๊ทผ์ฑ์ ๋ณด์ฅํ๋ ค๋ฉดaria-disabled๋ก ์ ํํ๊ณ ๋นํ์ฑ ํด๋ฆญ์ ํธ๋ค๋ฌ์์ ์ฐจ๋จํด์ผ ํฉ๋๋ค.apps/desktop/src/features/score/ScoreView.tsx#L201-L201: ํ๋ก์ ํธ๊ฐ ์์ ๋ ํด์งํต ๋ฒํผ์aria-disabled๋ฅผ ์ฌ์ฉํ์ธ์.apps/desktop/src/features/score/ScoreViewer.tsx#L297-L297: ์ฒซ ํ์ด์ง์ ์ด์ ๋ฒํผ์aria-disabled๋ฅผ ์ฌ์ฉํ์ธ์.apps/desktop/src/features/score/ScoreViewer.tsx#L311-L311: ๋ง์ง๋ง ํ์ด์ง์ ๋ค์ ๋ฒํผ์aria-disabled๋ฅผ ์ฌ์ฉํ์ธ์.๐ Affects 2 files
apps/desktop/src/features/score/ScoreView.tsx#L201-L201(this comment)apps/desktop/src/features/score/ScoreViewer.tsx#L297-L297apps/desktop/src/features/score/ScoreViewer.tsx#L311-L311๐ค Prompt for AI Agents
Source: Coding guidelines