Skip to content

⚡ Bolt: [성능 개선] - #715

Closed
seonghobae wants to merge 2 commits into
developfrom
bolt/optimize-array-every-16762904296077355084
Closed

⚡ Bolt: [성능 개선]#715
seonghobae wants to merge 2 commits into
developfrom
bolt/optimize-array-every-16762904296077355084

Conversation

@seonghobae

Copy link
Copy Markdown
Collaborator

💡 What: scoreStorage.ts의 바이트 배열 검증 로직에서 .every()for...of 루프와 조기 반환으로 교체했습니다.
🎯 Why: .every()는 콜백 함수 할당으로 인해 대용량 배열(예: PDF 바이트 데이터)에서 O(N) 중간 할당과 가비지 컬렉션 오버헤드를 유발합니다.
📊 Impact: O(1) 메모리 할당 및 가비지 컬렉션 오버헤드 감소로 대규모 파일 로딩 성능 개선.
🔬 Measurement: npm run test --workspace=apps/desktop를 실행하여 동작 확인 및 npm run check로 전체 테스트 통과 확인.


PR created automatically by Jules for task 16762904296077355084 started by @seonghobae

@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 19 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 0f043e91-5649-4320-b334-8613645f3edf

📥 Commits

Reviewing files that changed from the base of the PR and between f8343f5 and edad1ab.

⛔ Files ignored due to path filters (1)
  • services/analysis-engine/uv.lock is excluded by !**/*.lock
📒 Files selected for processing (3)
  • .jules/bolt.md
  • apps/desktop/src/features/score/scoreStorage.test.ts
  • apps/desktop/src/features/score/scoreStorage.ts

Comment @coderabbitai help to get the list of available commands.

seonghobae pushed a commit that referenced this pull request Jul 29, 2026
trivy-fs on the branch head flagged one remaining Medium+ finding (setuptools
was cleared and the torch/cuda cascade introduced none): yt-dlp
CVE-2026-55404 (HIGH, CVSS 7.5 — .url/.desktop shortcut-file injection via
attacker-controlled webpage_url/filename in --write-link/--write-url-link/
--write-desktop-link, leading to downstream RCE if the shortcut is opened).
This advisory postdates the PR #715 scan, so the trivy DB now matches the
pinned yt-dlp 2026.6.9; the fix is 2026.7.4.

yt-dlp is a direct dependency: bumped the floor `>=2026.6.9` -> `>=2026.7.4`
in services/analysis-engine/pyproject.toml and re-locked surgically with
`uv lock --upgrade-package yt-dlp` (only yt-dlp changed: 2026.6.9 -> 2026.7.4).

Local verification (all pass):
- uv sync --project services/analysis-engine --group dev --frozen: ok
- pip-audit --local --strict: No known vulnerabilities found
- analysis-engine pytest --cov --cov-fail-under=100: 657 passed, 24 skipped, 100%
- npm ci consistent; npm audit --workspaces --audit-level=high: 0 vulnerabilities
- npm run build / test / lint / typecheck: pass (desktop 194 tests + shared-types
  20 tests, 100% coverage; mypy --strict clean; supply-chain/doc/bandit gates green)
- trivy not installed locally; yt-dlp is now 2026.7.4, exactly the fixed version
  trivy demanded, corroborated by clean pip-audit

No security gate weakened; no ignores added.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AzUnTqFnQqhRbaopvDdag7
@seonghobae

Copy link
Copy Markdown
Collaborator Author

Closing as closed-obsolete (bolt perf micro-PR storm) by autonomous product-completion loop.

Winner / disposition target: #727

Unique value from this cluster is consolidated there (projectId path guard + npm HIGH CVE pins + Foote novelty kernel sign). Remaining micro-duplicates do not land additional commercial readiness.

@seonghobae

Copy link
Copy Markdown
Collaborator Author

closed-closed-obsolete (bolt perf micro-PR storm) → #727

@seonghobae seonghobae closed this Jul 31, 2026
@google-labs-jules

Copy link
Copy Markdown

Closing as closed-obsolete (bolt perf micro-PR storm) by autonomous product-completion loop.

Winner / disposition target: #727

Unique value from this cluster is consolidated there (projectId path guard + npm HIGH CVE pins + Foote novelty kernel sign). Remaining micro-duplicates do not land additional commercial readiness.

Understood. Acknowledging that this work is now obsolete and stopping work on this task.

@google-labs-jules

Copy link
Copy Markdown

closed-closed-obsolete (bolt perf micro-PR storm) → #727

Understood. Acknowledging that this work is now obsolete and stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant