Skip to content

feat(chords): surface actionable rehearsal guidance - #776

Open
seonghobae wants to merge 3 commits into
developfrom
feat/chords-rehearsal-guidance-clean
Open

feat(chords): surface actionable rehearsal guidance#776
seonghobae wants to merge 3 commits into
developfrom
feat/chords-rehearsal-guidance-clean

Conversation

@seonghobae

Copy link
Copy Markdown
Collaborator

Buyer-visible gap

The Chords view exposed harmony and transposition but discarded three analysis outputs that musicians need before rehearsal: setup instructions, simplification guidance, and overlap warnings. The previous automation branch also rendered the legacy none sentinel as if it were real advice and carried unrelated npm lock drift.

Change

  • render setup notes, simplification guidance, and overlap warnings for each role;
  • normalize surrounding whitespace without mutating the analysis result;
  • suppress empty, whitespace-only, and case-insensitive none sentinel values;
  • filter empty warning entries while preserving meaningful warning order;
  • expose each role card as a named article so assistive technology and tests can scope its guidance;
  • remove the unused chord-collection pass rather than extending dead state;
  • update CHANGELOG.md under Unreleased;
  • introduce no dependency, lockfile, workflow, database, network, filesystem, model, or IPC change.

Test-first evidence

Commit df62f6ea4fb816b961e56f194528d2da83d8d452 added the role-scoped behavior contracts before production implementation. Commit d34b4e982f9750a5e6b4dcf5b2a17a3b37e2435e implemented the minimal presentation boundary. The branch differs from protected develop in exactly three files.

Merge gate

Require current-head desktop lint, strict typecheck, complete measured tests, production build, repository CI, Security Scan, SAST, central coverage/review, zero unresolved actionable threads, a qualifying independent non-author approval, and every branch-protection rule. No predecessor-head result or administrative bypass is accepted.

Supersedes #773.

@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 18 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 9dd33c07-014b-4321-9577-3201c938d5b5

📥 Commits

Reviewing files that changed from the base of the PR and between acdbea6 and 63d7c10.

📒 Files selected for processing (3)
  • CHANGELOG.md
  • apps/desktop/src/features/chords/index.test.tsx
  • apps/desktop/src/features/chords/index.tsx

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant