Skip to content

🎨 Palette: 테이블 작업 버튼에 대한 문맥 기반 aria-label 추가 및 접근성 개선 - #202

Closed
seonghobae wants to merge 1 commit into
mainfrom
palette-aria-labels-16176689438100118634
Closed

🎨 Palette: 테이블 작업 버튼에 대한 문맥 기반 aria-label 추가 및 접근성 개선#202
seonghobae wants to merge 1 commit into
mainfrom
palette-aria-labels-16176689438100118634

Conversation

@seonghobae

@seonghobae seonghobae commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator

Superseded by #162.

- 화면 판독기 사용자를 위해 반복적인 테이블 작업 버튼에 동적 aria-label 추가
- 로딩 상태 시 aria-label 업데이트 및 복원 로직 구현
- `.jules/palette.md`에 접근성 개선 학습 내용 추가
Copilot AI review requested due to automatic review settings July 24, 2026 21:45
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves the accessibility of the demo viewer’s history table actions by adding context-aware aria-labels for repetitive buttons/links and by updating the aria-label during async loading states to provide clearer screen reader feedback. It also records the learning in the Palette journal.

Changes:

  • Added optional ariaLabel support to createLink and createActionButton, and applied row-specific aria-labels using the job’s filename.
  • Updated the “Details” async action to preserve and restore the original aria-label while showing a loading state.
  • Added a new .jules/palette.md entry documenting the screen-reader learnings.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/main/resources/static/assets/viewer/demo.js Adds contextual aria-labels for table actions and improves loading-state a11y behavior.
.jules/palette.md Documents the new accessibility learnings for repetitive actions and loading states.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +157 to 160
const originalAriaLabel = btn.getAttribute("aria-label");
btn.disabled = true;
btn.setAttribute("aria-label", "Loading...");
btn.textContent = "Loading...";
@seonghobae seonghobae closed this Aug 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants