π¨ Palette: ν₯μλ ν μ΄λΈ μ‘μ λ²νΌ μ κ·Όμ± (ARIA λΌλ²¨ μΆκ°) - #207
π¨ Palette: ν₯μλ ν
μ΄λΈ μ‘μ
λ²νΌ μ κ·Όμ± (ARIA λΌλ²¨ μΆκ°)#207seonghobae wants to merge 1 commit into
Conversation
- Added an optional `ariaLabel` parameter to the `createLink` and `createActionButton` functions in `demo.js`. - Implemented dynamically generated `aria-label` attributes for repetitive table buttons (Details, Status JSON, Open viewer) that include the relevant document's filename, greatly enhancing screen reader accessibility. - Implemented logic to temporarily update the `aria-label` of the 'Details' button to "Loading..." when its visual state is asynchronously loading, ensuring state changes are properly conveyed, and restoring it afterward. - Appended a UX journal entry documenting this asynchronous `aria-label` loading state pattern.
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
There was a problem hiding this comment.
Pull request overview
λ°λͺ¨ λ·°μ΄μ μμ
νμ€ν 리 ν
μ΄λΈμμ λ°λ³΅λλ μ‘μ
λ²νΌ/λ§ν¬λ₯Ό μ€ν¬λ¦°λ¦¬λκ° κ΅¬λΆν μ μλλ‘ μ»¨ν
μ€νΈ(νμΌλͺ
)λ₯Ό ν¬ν¨ν λμ aria-labelμ μΆκ°νκ³ , λΉλκΈ° λ‘λ© μν λμ aria-labelλ ν¨κ» κ°±μ /볡μνλλ‘ κ°μ ν PRμ
λλ€.
Changes:
- ν
μ΄λΈ μ‘μ
λ²νΌ/λ§ν¬μ 컨ν
μ€νΈλ³
aria-label(νμΌλͺ ν¬ν¨) μΆκ° - βDetailsβ λΉλκΈ° λμμμ λ‘λ© μν μ§μ
/ν΄μ μ
aria-labelλ μμ μ λ°μ΄νΈ ν μ볡 - λ³κ²½ μ¬νμ CHANGELOG λ° Jules νλ νΈ λ¬Έμμ κΈ°λ‘
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/main/resources/static/assets/viewer/demo.js | ν
μ΄λΈ μ‘μ
μ νμΌλͺ
κΈ°λ° aria-labelμ λΆμ¬νκ³ , λ‘λ© μνμμ aria-labelμ μμ λ³κ²½ ν 볡μ |
| CHANGELOG.md | μ κ·Όμ± κ°μ μ¬νμ Unreleased λ³κ²½ λ΄μμ μΆκ° |
| .jules/palette.md | λ°λ³΅ μ‘μ λ²νΌμ 컨ν μ€νΈλ³ ARIA λΌλ²¨ λ° λ‘λ© μν μ λΌλ²¨ κ°±μ /볡μμ λν νμ΅/μ‘μ κΈ°λ‘ μΆκ° |
π‘ Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| ### Fixed | ||
| - νλ©΄ νλ κΈ°λ₯Ό μ¬μ©νλ μ¬μ©μλ₯Ό μν΄ λ°λ³΅μ μΈ ν μ΄λΈ μ‘μ λ²νΌ("μΈλΆ μ 보", "μν JSON", "λ·°μ΄ μ΄κΈ°")μ νμΌλͺ μ΄ ν¬ν¨λ λμ μΈ `aria-label` μμ±μ μ 곡νμ¬ μ κ·Όμ±μ κ°μ νμ΅λλ€. | ||
| - "μΈλΆ μ 보" λ²νΌκ³Ό κ°μ λΉλκΈ° μ‘μ λ²νΌμ΄ "λ‘λ© μ€..." μνλ‘ λ³κ²½λ λ `aria-label`λ μμλ‘ μ λ°μ΄νΈνμ¬ μ€ν¬λ¦° 리λ μ¬μ©μκ° λ‘λ© μνλ₯Ό μΈμν μ μλλ‘ νκ³ , μμ μλ£ ν μλ λΌλ²¨λ‘ μ¬λ°λ₯΄κ² 볡μλλλ‘ μμ νμ΅λλ€. |
| **Learning:** Adding explicit loading and disabled states to table action buttons that invoke asynchronous processes helps prevent redundant API calls and visually assures the user that their request is being handled. | ||
| **Action:** Consistently apply `disabled` state and `Loading...` text changes to inline table action buttons linked to async workflows, and carefully preserve underlying DOM structures with `Array.from(btn.childNodes)` during the loading cycle to avoid rendering regressions. | ||
|
|
||
| ## 2024-07-25 - Context-Specific ARIA Labels and Asynchronous Loading States |
Superseded by #162.