🎨 Palette: 비동기 버튼 로딩 상태 접근성 개선 (aria-busy) - #217
Conversation
- `demo.js` 내 비동기 작업(새로고침, 재시도, 제출 등)을 수행하는 5개의 액션 버튼에 로딩 상태를 명시적으로 나타내는 `aria-busy="true"` 속성을 추가함 - 작업이 완료된 후 `finally` 블록에서 `aria-busy` 속성을 제거하여 원래 상태로 복원함 - 이 변경 사항은 스크린 리더 사용자에게 로딩 중 상태를 명확히 전달하여 접근성을 크게 향상시킴 - 관련 학습 내용을 `.jules/palette.md` 파일에 기록함
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Warning Review limit reached
Next review available in: 6 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Pull request overview
This PR improves the demo viewer’s accessibility by explicitly signaling “in-progress” states on buttons that trigger asynchronous network operations, using aria-busy toggling alongside existing disabled + label changes.
Changes:
- Toggle
aria-busy="true"on key async-action buttons at request start, and remove it infinally/.finally()when the operation completes. - Document the accessibility learning/action in
.jules/palette.mdfor future consistency.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/main/resources/static/assets/viewer/demo.js | Adds aria-busy set/remove around async button workflows (Details, Retry, Refresh evidence, Load demo data, Submit). |
| .jules/palette.md | Records the rationale/pattern for using aria-busy for async button accessibility. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Superseded by #162.