Skip to content

๐ŸŽจ Palette: ๋™์  ์š”์†Œ ์ ‘๊ทผ์„ฑ ๊ฐœ์„  (aria-busy ๋ฐ aria-label) - #291

Closed
seonghobae wants to merge 1 commit into
mainfrom
jules-6190292123394483182-ef68cc10
Closed

๐ŸŽจ Palette: ๋™์  ์š”์†Œ ์ ‘๊ทผ์„ฑ ๊ฐœ์„  (aria-busy ๋ฐ aria-label)#291
seonghobae wants to merge 1 commit into
mainfrom
jules-6190292123394483182-ef68cc10

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

๐Ÿ’ก What: ๋น„๋™๊ธฐ ํ˜ธ์ถœ ์ค‘ ๋ฒ„ํŠผ์— aria-busy="true" ์†์„ฑ์„ ์ถ”๊ฐ€ํ•˜๊ณ  renderHistory์˜ ๋™์  ๋ฒ„ํŠผ๋“ค์— ํŒŒ์ผ๋ช…์„ ํฌํ•จํ•œ aria-label์„ ๋ถ€์—ฌํ–ˆ์Šต๋‹ˆ๋‹ค.
๐ŸŽฏ Why: ์Šคํฌ๋ฆฐ ๋ฆฌ๋” ๋“ฑ ๋ณด์กฐ ๊ธฐ๊ธฐ๋ฅผ ์‚ฌ์šฉํ•˜๋Š” ์‚ฌ์šฉ์ž๊ฐ€ ๋กœ๋”ฉ ์ƒํƒœ๋ฅผ ๋ช…ํ™•ํžˆ ์ธ์ง€ํ•˜๊ณ , ๋™์ผํ•œ ํ…์ŠคํŠธ์˜ ๋ฐ˜๋ณต๋œ ๋ฒ„ํŠผ๋“ค ์‚ฌ์ด์—์„œ ๋งฅ๋ฝ์„ ํŒŒ์•…ํ•  ์ˆ˜ ์žˆ๋„๋ก ํ•˜๊ธฐ ์œ„ํ•จ์ž…๋‹ˆ๋‹ค.
โ™ฟ Accessibility: ๋น„๋™๊ธฐ ํ†ต์‹  ์ค‘ ๋กœ๋”ฉ ์ƒํƒœ ์ œ๊ณต(aria-busy) ๋ฐ ์‹œ๊ฐ์ ์œผ๋กœ ์ˆจ๊ฒจ์ง„ ๋งฅ๋ฝ ์‹๋ณ„์ž(aria-label) ์ถ”๊ฐ€๋ฅผ ํ†ตํ•ด WCAG ์ง€์นจ ์ค€์ˆ˜.


PR created automatically by Jules for task 6190292123394483182 started by @seonghobae

Summary by CodeRabbit

  • ์ ‘๊ทผ์„ฑ ๊ฐœ์„ 
    • ๋น„๋™๊ธฐ ์ž‘์—… ์ง„ํ–‰ ์ค‘ ์Šคํฌ๋ฆฐ ๋ฆฌ๋”์— ๋กœ๋”ฉ ์ƒํƒœ๋ฅผ ์•Œ๋ฆฌ๋„๋ก ๊ฐœ์„ ํ–ˆ์Šต๋‹ˆ๋‹ค.
    • ์ƒ์„ธ ๋ณด๊ธฐ, ์ƒํƒœ ์ •๋ณด, ๋ทฐ์–ด ๋งํฌ์— ํŒŒ์ผ๋ช… ๊ธฐ๋ฐ˜์˜ ๊ตฌ์ฒด์ ์ธ ์ ‘๊ทผ์„ฑ ๋ผ๋ฒจ์„ ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค.
    • ๋ฐ˜๋ณต๋˜๋Š” ๋ฒ„ํŠผ์—๋„ ๊ฐ ํ•ญ๋ชฉ์„ ๊ตฌ๋ถ„ํ•  ์ˆ˜ ์žˆ๋Š” ๋ผ๋ฒจ์„ ์ œ๊ณตํ•ฉ๋‹ˆ๋‹ค.
    • ์ž‘์—… ์™„๋ฃŒ ์‹œ ๋กœ๋”ฉ ์ƒํƒœ๊ฐ€ ์ž๋™์œผ๋กœ ํ•ด์ œ๋ฉ๋‹ˆ๋‹ค.

@google-labs-jules

Copy link
Copy Markdown

๐Ÿ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a ๐Ÿ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. ๐ŸŽ‰

โ„น๏ธ Recent review info
โš™๏ธ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: bde6b78a-a76b-41ce-bcd2-7123352de0c9

๐Ÿ“ฅ Commits

Reviewing files that changed from the base of the PR and between f3cc09a and f6ae6bd.

๐Ÿ“’ Files selected for processing (2)
  • .jules/palette.md
  • src/main/resources/static/assets/viewer/demo.js

๐Ÿ“ Walkthrough

Walkthrough

demo.js์— ํŒŒ์ผ๋ช… ๊ธฐ๋ฐ˜ aria-label์„ ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค. ๋น„๋™๊ธฐ ์ž‘์—… ๋ฒ„ํŠผ์€ ์ฒ˜๋ฆฌ ์ค‘ aria-busy="true"๋ฅผ ์„ค์ •ํ•˜๊ณ  ์™„๋ฃŒ ์‹œ ์ œ๊ฑฐํ•ฉ๋‹ˆ๋‹ค. ์ ‘๊ทผ์„ฑ ์ง€์นจ ๋ฌธ์„œ๋„ ๊ฐฑ์‹ ํ–ˆ์Šต๋‹ˆ๋‹ค.

Changes

์ ‘๊ทผ์„ฑ ๊ฐœ์„ 

Layer / File(s) Summary
์ปจํ…์ŠคํŠธ ๊ธฐ๋ฐ˜ ์ ‘๊ทผ์„ฑ ๋ผ๋ฒจ
src/main/resources/static/assets/viewer/demo.js, .jules/palette.md
๋งํฌ์™€ ๋ฒ„ํŠผ ์ƒ์„ฑ ํ•จ์ˆ˜๊ฐ€ ์„ ํƒ์  aria-label์„ ์ง€์›ํ•ฉ๋‹ˆ๋‹ค. ์ƒ์„ธ ๋ณด๊ธฐ, ์ƒํƒœ JSON, ๋ทฐ์–ด ๋งํฌ์— ํŒŒ์ผ๋ช… ๊ธฐ๋ฐ˜ ๋ผ๋ฒจ์„ ์ ์šฉํ•ฉ๋‹ˆ๋‹ค. ํŒŒ์ผ๋ช… ๊ธฐ๋ณธ๊ฐ’์€ ํ…Œ์ด๋ธ” ํ‘œ์‹œ์™€ ๋ผ๋ฒจ ์ƒ์„ฑ์— ํ•จ๊ป˜ ์‚ฌ์šฉํ•ฉ๋‹ˆ๋‹ค.
๋น„๋™๊ธฐ ์ž‘์—… ์ƒํƒœ ํ‘œ์‹œ
src/main/resources/static/assets/viewer/demo.js
์ƒ์„ธ ๋ณด๊ธฐ, ์žฌ์‹œ๋„, KPI ์ฆ๊ฑฐ ์ƒˆ๋กœ ๊ณ ์นจ, ์‹œ๋“œ ๋ฐ์ดํ„ฐ ๋กœ๋“œ, ๋ฌธ์„œ ์ œ์ถœ ๋ฒ„ํŠผ์ด ์ฒ˜๋ฆฌ ์ค‘ aria-busy="true"๋ฅผ ์„ค์ •ํ•˜๊ณ  ์™„๋ฃŒ ์‹œ ์†์„ฑ์„ ์ œ๊ฑฐํ•ฉ๋‹ˆ๋‹ค.

Estimated code review effort: 2 (Simple) | ~10 minutes

๐Ÿšฅ Pre-merge checks | โœ… 5
โœ… Passed checks (5 passed)
Check name Status Explanation
Description Check โœ… Passed Check skipped - CodeRabbitโ€™s high-level summary is enabled.
Title check โœ… Passed ์ œ๋ชฉ์€ aria-busy์™€ aria-label์„ ์‚ฌ์šฉํ•œ ๋™์  ์š”์†Œ ์ ‘๊ทผ์„ฑ ๊ฐœ์„ ์ด๋ผ๋Š” ์ฃผ์š” ๋ณ€๊ฒฝ ์‚ฌํ•ญ์„ ๋ช…ํ™•ํ•˜๊ณ  ๊ฐ„๊ฒฐํ•˜๊ฒŒ ์„ค๋ช…ํ•ฉ๋‹ˆ๋‹ค.
Docstring Coverage โœ… Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check โœ… Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check โœ… Passed Check skipped because no linked issues were found for this pull request.
โœจ Finishing Touches
๐Ÿ“ Generate docstrings
  • Create stacked PR
  • Commit on current branch
๐Ÿงช Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jules-6190292123394483182-ef68cc10

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Collaborator Author

Closing as superseded by #264. This PR duplicates the same accessibility objective but implements one-shot aria-busy/label mutations directly in demo.js without #264's nested-safe busy-state depth, exact restoration of pre-existing disabled/ARIA/child-node state, duplicate-activation guard, inert-label boundary, or deterministic Node coverage contract. #264 already contains the broader tested implementation on the current #270 parent ancestry. Keeping both would create conflicting duplicate behavior and review noise.

@seonghobae seonghobae closed this Aug 6, 2026
@google-labs-jules

Copy link
Copy Markdown

Closing as superseded by #264. This PR duplicates the same accessibility objective but implements one-shot aria-busy/label mutations directly in demo.js without #264's nested-safe busy-state depth, exact restoration of pre-existing disabled/ARIA/child-node state, duplicate-activation guard, inert-label boundary, or deterministic Node coverage contract. #264 already contains the broader tested implementation on the current #270 parent ancestry. Keeping both would create conflicting duplicate behavior and review noise.

Understood. Acknowledging that this work is now superseded by #264 and stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant