Skip to content

🎨 Palette: [UX improvement] ν΄λΌμ΄μ–ΈνŠΈ μΈ‘ 파일 크기 μœ νš¨μ„± 검사 λ©”μ‹œμ§€ 동적 ν¬λ§·νŒ… - #289

Closed
seonghobae wants to merge 2 commits into
mainfrom
palette-dynamic-file-size-limit-13587182850221175719
Closed

🎨 Palette: [UX improvement] ν΄λΌμ΄μ–ΈνŠΈ μΈ‘ 파일 크기 μœ νš¨μ„± 검사 λ©”μ‹œμ§€ 동적 ν¬λ§·νŒ…#289
seonghobae wants to merge 2 commits into
mainfrom
palette-dynamic-file-size-limit-13587182850221175719

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

πŸ’‘ What: μžλ°”μŠ€ν¬λ¦½νŠΈ 파일 크기 μœ νš¨μ„± κ²€μ‚¬μ—μ„œ ν•˜λ“œμ½”λ”©λœ '5 GiB' ν…μŠ€νŠΈλ₯Ό MAX_UPLOAD_BYTES μƒμˆ˜λ₯Ό 기반으둜 동적 ν¬λ§·νŒ…λ˜λ„λ‘ μˆ˜μ •ν–ˆμŠ΅λ‹ˆλ‹€.
🎯 Why: μ„€μ •λœ μ΅œλŒ€ 파일 크기 μ œν•œ μƒμˆ˜κ°’μ΄ λ³€κ²½λ˜λ”λΌλ„ μ‚¬μš©μžμ—κ²Œ μ •ν™•ν•œ 크기 μ œν•œ λ©”μ‹œμ§€λ₯Ό μ œκ³΅ν•˜μ—¬ ν˜Όλž€μ„ λ°©μ§€ν•˜κΈ° μœ„ν•¨μž…λ‹ˆλ‹€.
πŸ“Έ Before/After: ν•˜λ“œμ½”λ”© λ¬Έμžμ—΄ -> formatBinaryBytes(MAX_UPLOAD_BYTES) ν™œμš©μœΌλ‘œ λ³€κ²½.
β™Ώ Accessibility: 슀크린 λ¦¬λ”μ—μ„œ μ½νžˆλŠ” aria-invalid μƒνƒœ 및 미리보기 ν…μŠ€νŠΈκ°€ 항상 μ‹€μ œ μ‹œμŠ€ν…œ μ œν•œκ³Ό μΌμΉ˜ν•˜λ„λ‘ 보μž₯ν•©λ‹ˆλ‹€.


PR created automatically by Jules for task 13587182850221175719 started by @seonghobae

Copilot AI review requested due to automatic review settings July 24, 2026 22:13
@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the FastAPI SaaS upload UI’s client-side file-size validation messaging so the human-readable limit is derived from the MAX_UPLOAD_BYTES constant (via formatBinaryBytes(MAX_UPLOAD_BYTES)) instead of a hardcoded β€œ5 GiB”, keeping the UX accurate if the limit changes.

Changes:

  • Replace hardcoded β€œ5 GiB” validation/preview text with dynamically formatted limitText in the upload UI JavaScript.
  • Update the UI snapshot-style test to assert the new dynamic formatting logic/strings.
  • Document the UX improvement in the changelog and capture the β€œno hardcoded limits” guideline in the palette notes.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
saas_web.py Uses formatBinaryBytes(MAX_UPLOAD_BYTES) to build user-facing oversize messages dynamically.
tests/test_saas_web.py Adjusts assertions to match the new dynamic limit formatting in the rendered HTML.
CHANGELOG.md Records the UX improvement in the Unreleased notes.
.jules/palette.md Adds a learning/action note to avoid hardcoded human-readable limits in validation messages.

πŸ’‘ Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@opencode-agent[bot], you've reached your PR review limit, so we couldn't start this review.

Next review available in: 25 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
βš™οΈ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 5ad3ed48-d85b-446f-b7ce-d41852a98818

πŸ“₯ Commits

Reviewing files that changed from the base of the PR and between 963291f and d212263.

πŸ“’ Files selected for processing (4)
  • .jules/palette.md
  • CHANGELOG.md
  • saas_web.py
  • tests/test_saas_web.py

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Contributor Author

Superseded by merged PR #354, which provides the same dynamic upload-limit feedback and combined batch-size validation. Closing this duplicate to keep a single maintained implementation.

@seonghobae seonghobae closed this Aug 7, 2026
@google-labs-jules

Copy link
Copy Markdown

Superseded by merged PR #354, which provides the same dynamic upload-limit feedback and combined batch-size validation. Closing this duplicate to keep a single maintained implementation.

Understood. Acknowledging that this work is now obsolete and stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants