π¨ Palette: [UX improvement] ν΄λΌμ΄μΈνΈ μΈ‘ νμΌ ν¬κΈ° μ ν¨μ± κ²μ¬ λ©μμ§ λμ ν¬λ§·ν - #289
Conversation
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
There was a problem hiding this comment.
Pull request overview
Updates the FastAPI SaaS upload UIβs client-side file-size validation messaging so the human-readable limit is derived from the MAX_UPLOAD_BYTES constant (via formatBinaryBytes(MAX_UPLOAD_BYTES)) instead of a hardcoded β5 GiBβ, keeping the UX accurate if the limit changes.
Changes:
- Replace hardcoded β5 GiBβ validation/preview text with dynamically formatted
limitTextin the upload UI JavaScript. - Update the UI snapshot-style test to assert the new dynamic formatting logic/strings.
- Document the UX improvement in the changelog and capture the βno hardcoded limitsβ guideline in the palette notes.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
saas_web.py |
Uses formatBinaryBytes(MAX_UPLOAD_BYTES) to build user-facing oversize messages dynamically. |
tests/test_saas_web.py |
Adjusts assertions to match the new dynamic limit formatting in the rendered HTML. |
CHANGELOG.md |
Records the UX improvement in the Unreleased notes. |
.jules/palette.md |
Adds a learning/action note to avoid hardcoded human-readable limits in validation messages. |
π‘ Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Warning Review limit reached
Next review available in: 25 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review detailsβοΈ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: π Files selected for processing (4)
Comment |
|
Superseded by merged PR #354, which provides the same dynamic upload-limit feedback and combined batch-size validation. Closing this duplicate to keep a single maintained implementation. |
Understood. Acknowledging that this work is now obsolete and stopping work on this task. |
π‘ What: μλ°μ€ν¬λ¦½νΈ νμΌ ν¬κΈ° μ ν¨μ± κ²μ¬μμ νλμ½λ©λ '5 GiB' ν μ€νΈλ₯Ό
MAX_UPLOAD_BYTESμμλ₯Ό κΈ°λ°μΌλ‘ λμ ν¬λ§·ν λλλ‘ μμ νμ΅λλ€.π― Why: μ€μ λ μ΅λ νμΌ ν¬κΈ° μ ν μμκ°μ΄ λ³κ²½λλλΌλ μ¬μ©μμκ² μ νν ν¬κΈ° μ ν λ©μμ§λ₯Ό μ 곡νμ¬ νΌλμ λ°©μ§νκΈ° μν¨μ λλ€.
πΈ Before/After: νλμ½λ© λ¬Έμμ΄ ->
formatBinaryBytes(MAX_UPLOAD_BYTES)νμ©μΌλ‘ λ³κ²½.βΏ Accessibility: μ€ν¬λ¦° 리λμμ μ½νλ
aria-invalidμν λ° λ―Έλ¦¬λ³΄κΈ° ν μ€νΈκ° νμ μ€μ μμ€ν μ νκ³Ό μΌμΉνλλ‘ λ³΄μ₯ν©λλ€.PR created automatically by Jules for task 13587182850221175719 started by @seonghobae