🛡️ Sentinel: [HIGH] 비 ASCII 문자를 통한 hmac.compare_digest DoS 취약점 수정

[seonghobae]

🚨 Severity: HIGH
💡 Vulnerability: hmac.compare_digest()를 사용하여 API 키를 비교할 때, 비 ASCII 문자가 포함된 문자열이 입력되면 TypeError가 발생하여 어플리케이션 크래시(500 Server Error)를 유발할 수 있습니다.
🎯 Impact: 악의적인 공격자가 조작된 x-api-key 헤더를 반복적으로 전송하여 서버 자원을 고갈시키는 서비스 거부(DoS) 공격을 수행할 수 있습니다.
🔧 Fix: hmac.compare_digest()를 호출하기 전에 입력된 API 키와 설정된 키를 모두 utf-8 바이트로 인코딩하여 안전하게 비교하도록 수정했습니다.
✅ Verification: 비 ASCII 문자가 포함된 헤더를 전송하는 테스트 코드를 작성하여 정상적으로 401 오류가 반환됨을 확인했습니다.

---

PR created automatically by Jules for task 1679098434707941554 started by @seonghobae

Summary by CodeRabbit

• 버그 수정

  • 비ASCII 문자가 포함된 API 키를 사용할 때 발생할 수 있는 서버 오류를 수정했습니다.
  • API 키 인증이 예기치 않게 중단되거나 서비스 거부로 이어지는 문제를 방지했습니다.

• 문서

  • 관련 보안 취약점과 대응 방법을 문서화했습니다.

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: aa019451-dace-4011-9f52-8df6ad08ca92

📥 Commits

Reviewing files that changed from the base of the PR and between 5a92586 and e8c6f9d.

📒 Files selected for processing (2)

• .jules/sentinel.md
• saas_web.py

---

📝 Walkthrough

Walkthrough

API 키 인증 비교 시 양쪽 문자열을 UTF-8 바이트로 변환하도록 수정하고, 비 ASCII 입력으로 인한 TypeError 및 500 오류 대응 내용을 문서화했습니다.

Changes

API 키 인증 보완

Layer / File(s)	Summary
UTF-8 바이트 기반 API 키 비교 saas_web.py, .jules/sentinel.md	require_api_key가 구성된 키와 제공된 키를 UTF-8 바이트로 인코딩해 비교하며, 관련 취약점과 예방 지침이 문서에 추가되었습니다.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	제목이 비 ASCII 문자를 통한 hmac.compare_digest DoS 취약점 수정이라는 핵심 변경을 정확히 요약합니다.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch sentinel-hmac-dos-fix-1679098434707941554

---

_{Comment @coderabbitai help to get the list of available commands.}

[seonghobae]

Superseded by canonical PR #361, which includes the same non-ASCII comparison fix and consolidates credential access, owned result storage, retention cleanup, and failure-mode tests. Closing this duplicate.

[google-labs-jules]

Superseded by canonical PR #361, which includes the same non-ASCII comparison fix and consolidates credential access, owned result storage, retention cleanup, and failure-mode tests. Closing this duplicate.

Understood. Acknowledging that this work is now obsolete and stopping work on this task.