π¨ Palette: [UX improvement] λμ νμΌ ν¬κΈ° μ ν κ²μ¦ μΆκ° - #323
π¨ Palette: [UX improvement] λμ νμΌ ν¬κΈ° μ ν κ²μ¦ μΆκ°#323seonghobae wants to merge 1 commit into
Conversation
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π WalkthroughWalkthroughμ
λ‘λ μ©λ μ ν λ©μμ§κ° Changesμ λ‘λ μ©λ κ²μ¦
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
π₯ Pre-merge checks | β 5β Passed checks (5 passed)
β¨ Finishing Touchesπ Generate docstrings
π§ͺ Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
π§Ή Nitpick comments (1)
tests/test_saas_web.py (1)
53-56: π Maintainability & Code Quality | π΅ Trivial | β‘ Quick winν μ€νΈκ° μ€μ μ νκ° λκΈ°νλ₯Ό κ²μ¦ν΄μΌ ν©λλ€.
νμ¬ κ²μ¬λ
limitTextλ¬Έμμ΄μ μ‘΄μ¬λ§ νμΈνλ―λ‘, JavaScript μ νκ°μ΄ μλ²μsaas_web.MAX_UPLOAD_BYTESμ λ¬λΌλ ν΅κ³Όν©λλ€. λ λλ§λ HTMLμ μ€μ μ€μ κ°μ΄ μ£Όμ λμλμ§ νμΈνκ³ , λ¨μΌΒ·λ°°μΉ μ€λ₯ κ²½λ‘μaria-invalidμ²λ¦¬λ κ²μ¦ν΄ μ£ΌμΈμ.π€ Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tests/test_saas_web.py` around lines 53 - 56, Update the assertions in the relevant test to verify the rendered JavaScript limit uses the actual saas_web.MAX_UPLOAD_BYTES value, rather than only checking limitText strings. Also assert aria-invalid behavior for both single-file and batch upload error paths, covering the rendered HTML output.
π€ Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@saas_web.py`:
- Around line 233-236: Connect the browser upload limit to the serverβs
MAX_UPLOAD_BYTES instead of a separately hardcoded value: update saas_web.py
lines 233-236 to inject and use that setting for single-file validation and
messaging, and lines 329-336 to use the same injected limit for batch-total
validation. Update tests/test_saas_web.py lines 53-56 to inject the actual
configured limit and verify aria-invalid behavior.
---
Nitpick comments:
In `@tests/test_saas_web.py`:
- Around line 53-56: Update the assertions in the relevant test to verify the
rendered JavaScript limit uses the actual saas_web.MAX_UPLOAD_BYTES value,
rather than only checking limitText strings. Also assert aria-invalid behavior
for both single-file and batch upload error paths, covering the rendered HTML
output.
πͺ Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
βΉοΈ Review info
βοΈ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: d6c6b1a6-dd59-4b1a-b128-0db21db6f7fb
π Files selected for processing (4)
.jules/palette.mdCHANGELOG.mdsaas_web.pytests/test_saas_web.py
| const limitText = formatBinaryBytes(MAX_UPLOAD_BYTES); | ||
| input.setCustomValidity('File exceeds ' + limitText + ' limit.'); | ||
| input.setAttribute('aria-invalid', 'true'); | ||
| preview.innerText = 'Selected file size: ' + text + ' (exceeds 5 GiB limit)'; | ||
| preview.innerText = 'Selected file size: ' + text + ' (exceeds ' + limitText + ' limit)'; |
There was a problem hiding this comment.
ποΈ Data Integrity & Integration | π Major | β‘ Quick win
ν΄λΌμ΄μΈνΈ μ λ‘λ μ νκ³Ό ν μ€νΈλ₯Ό μλ² μ€μ μ μ°κ²°ν΄μΌ ν©λλ€.
λΈλΌμ°μ μ μ νκ°μ΄ μλ² μ€μ κ³Ό λ³λλ‘ νλμ½λ©λμ΄ μμ΄, μ€μ λ³κ²½ μ μ¬μ©μ λ©μμ§Β·κ²μ¦Β·μ€μ μλ² λμμ΄ λΆμΌμΉν μ μμ΅λλ€.
saas_web.py#L233-L236: λ¨μΌ νμΌ μ€λ₯ λ©μμ§κ° μλ²μMAX_UPLOAD_BYTESλ₯Ό μ¬μ©νλλ‘ κ°μ μ£Όμ ν©λλ€.saas_web.py#L329-L336: λ°°μΉ ν©μ° κ²μ¦λ λμΌνκ² μ£Όμ λ μ νκ°μ μ¬μ©ν©λλ€.tests/test_saas_web.py#L53-L56: μ€μ μ€μ κ° μ£Όμ κ³Όaria-invalidλμμ κ²μ¦νλλ‘ ν μ€νΈλ₯Ό 보κ°ν©λλ€.
π Affects 2 files
saas_web.py#L233-L236(this comment)saas_web.py#L329-L336tests/test_saas_web.py#L53-L56
π€ Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@saas_web.py` around lines 233 - 236, Connect the browser upload limit to the
serverβs MAX_UPLOAD_BYTES instead of a separately hardcoded value: update
saas_web.py lines 233-236 to inject and use that setting for single-file
validation and messaging, and lines 329-336 to use the same injected limit for
batch-total validation. Update tests/test_saas_web.py lines 53-56 to inject the
actual configured limit and verify aria-invalid behavior.
|
Superseded by merged PR #354, which provides the same dynamic limit rendering and aggregate batch-size guard with current-head tests. Closing this duplicate to keep one canonical implementation. |
1 participant
π‘ What:
νμΌ μ λ‘λ ν¬κΈ° μ ν μ΄κ³Ό μ λ°μνλ μλ¬ λ©μμ§λ₯Ό νλμ½λ©λ κ°(5 GiB) λμ μ΅λ μ€μ κ°(MAX_UPLOAD_BYTES)μ λμ μΌλ‘ λ³ννμ¬ νμνλλ‘ μμ νμ΅λλ€.
λν μΌκ΄(batch) μ λ‘λ μμλ μ λ‘λλλ λͺ¨λ νμΌμ μ 체 ν¬κΈ° ν©μ΄ μ νμ λμ§ μλμ§ μ¬μ μ κ²μ¦νμ¬ μ€λ₯ λ©μμ§λ₯Ό μΆλ ₯νλ κΈ°λ₯μ μΆκ°νμ΅λλ€.
π― Why:
λ΄λΆ μ ν κ°μ΄ λ³κ²½λ κ²½μ° μ¬μ©μμκ² μλͺ»λ μ 보λ₯Ό μ λ¬ν μ μλ λ¬Έμ λ₯Ό μλ°©νλ©°, λ°°μΉ μ λ‘λμ κ²½μ° μλ²μΈ‘μΌλ‘ μ λ‘λκ° μ§νλ ν κ±°μ λλ μν©μ λ§κΈ° μν΄ ν΄λΌμ΄μΈνΈ μΈ‘μμ μ¦κ°μ μΈ νΌλλ°±μ μ£Όκ³ μ ν¨μ λλ€.
πΈ Before/After:
Before: νμΌ ν¬κΈ° μ΄κ³Όμ νμ "5 GiB"λ‘ νμ, λ°°μΉ μ λ‘λμ μ΄ μ©λ μ΄κ³Ό μ ν λ―Έμ§μ
After: νμ¬ MAX_UPLOAD_BYTESμ λ§μΆμ΄ μ©λ μλ κ³μ°λμ΄ νμ, λ°°μΉ μ λ‘λ μ΄ μ©λ μ ν μ΄κ³Ό μ¬μ κ²½κ³ νμ
βΏ Accessibility:
ν¬κΈ° μ ν μ΄κ³Ό μ
aria-invalidμνκ° μ μ νκ² λ°μλκ³ μ¦μ μκ°μ μΈ μ€λ₯ μλ΄κ° κ°λ₯νλλ‘ κ°μ νμ¬ μ€ν¬λ¦° 리λ λ± λ³΄μ‘° κΈ°κΈ°λ₯Ό μ¬μ©νλ μ μ κ° λͺ ννκ² μ€λ₯ μν©μ μΈμ§ν μ μλλ‘ νμμ΅λλ€.PR created automatically by Jules for task 4520332721963242270 started by @seonghobae
Summary by CodeRabbit