Skip to content

๐ŸŽจ Palette: ํŒŒ์ผ ์šฉ๋Ÿ‰ ์ดˆ๊ณผ ์—๋Ÿฌ ๋ฉ”์‹œ์ง€ ๊ฐœ์„  - #360

Closed
seonghobae wants to merge 1 commit into
mainfrom
palette-dynamic-file-size-validation-1669556879496276780
Closed

๐ŸŽจ Palette: ํŒŒ์ผ ์šฉ๋Ÿ‰ ์ดˆ๊ณผ ์—๋Ÿฌ ๋ฉ”์‹œ์ง€ ๊ฐœ์„ #360
seonghobae wants to merge 1 commit into
mainfrom
palette-dynamic-file-size-validation-1669556879496276780

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

๐Ÿ’ก What: ์—…๋กœ๋“œ ํŒŒ์ผ ์šฉ๋Ÿ‰ ์ดˆ๊ณผ ์‹œ ํ•˜๋“œ์ฝ”๋”ฉ๋œ '5 GiB' ์—๋Ÿฌ ๋ฉ”์‹œ์ง€๋ฅผ ์ œ๊ฑฐํ•˜๊ณ , MAX_UPLOAD_BYTES ์ƒ์ˆ˜๋ฅผ ๊ธฐ๋ฐ˜์œผ๋กœ ๋™์ ์œผ๋กœ ๊ณ„์‚ฐ๋œ ์šฉ๋Ÿ‰์„ ํ‘œ์‹œํ•˜๋„๋ก ๋ณ€๊ฒฝํ–ˆ์Šต๋‹ˆ๋‹ค. ์ผ๊ด„ ์—…๋กœ๋“œ ํผ(batch input)์˜ ๊ฒฝ์šฐ ์ด ํŒŒ์ผ ํฌ๊ธฐ๊ฐ€ ๋ฐฑ์—”๋“œ ์ œํ•œ ์šฉ๋Ÿ‰์„ ์ดˆ๊ณผํ•˜๋Š”์ง€ ์—ฌ๋ถ€๋„ ํ•จ๊ป˜ ๊ฒ€์ฆํ•˜์—ฌ ์‚ฌ์ „์— ์˜ค๋ฅ˜๋ฅผ ๋ฐฉ์ง€ํ•ฉ๋‹ˆ๋‹ค.

๐ŸŽฏ Why: ๋ฐฑ์—”๋“œ ์ œํ•œ๊ฐ’์ด ๋ณ€๊ฒฝ๋˜๋”๋ผ๋„ ํด๋ผ์ด์–ธํŠธ ์ธก ์—๋Ÿฌ ๋ฉ”์‹œ์ง€์— ๋ณ€๊ฒฝ ์‚ฌํ•ญ์ด ์ž๋™์œผ๋กœ ๋ฐ˜์˜๋˜์–ด ์‚ฌ์šฉ์ž์—๊ฒŒ ์ž˜๋ชป๋œ ์ •๋ณด๋ฅผ ์ œ๊ณตํ•˜๋Š” ๋ฌธ์ œ๋ฅผ ๋ง‰๊ณ  ํ˜ผ๋ž€์„ ์ตœ์†Œํ™”ํ•˜๊ธฐ ์œ„ํ•จ์ž…๋‹ˆ๋‹ค. ์ผ๊ด„ ์—…๋กœ๋“œ ์‹œ์—๋„ ์‚ฌ์šฉ์ž๊ฐ€ ์šฉ๋Ÿ‰ ์ดˆ๊ณผ ์˜ค๋ฅ˜๋ฅผ ์„œ๋ฒ„์— ์ œ์ถœํ•˜๊ธฐ ์ „์— ๋ฏธ๋ฆฌ ์•Œ ์ˆ˜ ์žˆ๋„๋ก ํ•˜์—ฌ ๋ถˆํ•„์š”ํ•œ ๋Œ€๊ธฐ ์‹œ๊ฐ„์„ ์ค„์˜€์Šต๋‹ˆ๋‹ค.

๐Ÿ“ธ Before/After: ํŒŒ์ผ ์ œํ•œ ์šฉ๋Ÿ‰์ด ํ•˜๋“œ์ฝ”๋”ฉ๋œ '5 GiB'์—์„œ MAX_UPLOAD_BYTES ๊ฐ’์„ ๋™์ ์œผ๋กœ ๋ณ€ํ™˜ํ•œ ๊ฐ’(์˜ˆ: 5.00 GiB)์œผ๋กœ ํ‘œ์‹œ๋˜๋ฉฐ, ์ผ๊ด„ ์—…๋กœ๋“œ ์‹œ์—๋„ ์ด ํŒŒ์ผ ํฌ๊ธฐ ์ดˆ๊ณผ ์—ฌ๋ถ€๊ฐ€ ์˜ฌ๋ฐ”๋ฅด๊ฒŒ ํ‘œ์ถœ๋ฉ๋‹ˆ๋‹ค.

โ™ฟ Accessibility: setCustomValidity ๋ฐ aria-invalid ์ƒํƒœ ๋ณ€๊ฒฝ๊ณผ ๋”๋ถˆ์–ด aria-live ์˜์—ญ์— ์ฆ‰๊ฐ์ ์œผ๋กœ ์ดˆ๊ณผ๋œ ์šฉ๋Ÿ‰ ์—๋Ÿฌ ๋ฉ”์‹œ์ง€๋ฅผ ์ฃผ์ž…ํ•จ์œผ๋กœ์จ ํ™”๋ฉด ๋‚ญ๋…๊ธฐ(Screen Reader) ์‚ฌ์šฉ์ž๋„ ์šฉ๋Ÿ‰ ์ดˆ๊ณผ ์—ฌ๋ถ€๋ฅผ ์ฆ‰์‹œ ์ธ์ง€ํ•  ์ˆ˜ ์žˆ๋„๋ก ์ ‘๊ทผ์„ฑ์„ ๊ฐœ์„ ํ–ˆ์Šต๋‹ˆ๋‹ค.


PR created automatically by Jules for task 1669556879496276780 started by @seonghobae

@google-labs-jules

Copy link
Copy Markdown

๐Ÿ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a ๐Ÿ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 11 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
โš™๏ธ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 66b7d8f1-4842-4ba7-999a-6474ea99b4f3

๐Ÿ“ฅ Commits

Reviewing files that changed from the base of the PR and between 963291f and ad969a2.

๐Ÿ“’ Files selected for processing (5)
  • .jules/palette.md
  • CHANGELOG.md
  • pr_description.txt
  • saas_web.py
  • tests/test_saas_web.py

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Contributor Author

Closing in favor of the narrower #365, and because this branch introduces a client/server contract mismatch.

The backend enforces MAX_UPLOAD_BYTES independently for each uploaded file in the batch loop; it does not enforce one aggregate batch-byte ceiling equal to the single-file ceiling. This PR makes the browser reject a batch whenever the sum exceeds MAX_UPLOAD_BYTES, so several individually valid files can be blocked even though the server accepts them. Client validation must not invent a stricter limit without a separately designed and enforced aggregate server contract, capacity model, error response, documentation, and tests.

The valid partโ€”deriving the single-file message from the active constantโ€”is isolated in #365. That maintained slice still needs behavior-level validation and removal of bot-journal metadata, but it does not add the unsupported aggregate restriction. No check or review from this branch transfers.

@google-labs-jules

Copy link
Copy Markdown

Closing in favor of the narrower #365, and because this branch introduces a client/server contract mismatch.

The backend enforces MAX_UPLOAD_BYTES independently for each uploaded file in the batch loop; it does not enforce one aggregate batch-byte ceiling equal to the single-file ceiling. This PR makes the browser reject a batch whenever the sum exceeds MAX_UPLOAD_BYTES, so several individually valid files can be blocked even though the server accepts them. Client validation must not invent a stricter limit without a separately designed and enforced aggregate server contract, capacity model, error response, documentation, and tests.

The valid partโ€”deriving the single-file message from the active constantโ€”is isolated in #365. That maintained slice still needs behavior-level validation and removal of bot-journal metadata, but it does not add the unsupported aggregate restriction. No check or review from this branch transfers.

Understood. Acknowledging that this PR introduces a client/server contract mismatch regarding the batch upload limit and is closed in favor of #365. I am stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant