Skip to content

⚡ Bolt: 디렉토리 처리 루프의 정적 에셋 해싱 및 재할당 방지 #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
seonghobae wants to merge 3 commits into from
Closed

⚡ Bolt: 디렉토리 처리 루프의 정적 에셋 해싱 및 재할당 방지 #303

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
98bcc78
⚡ Bolt: 디렉토리 처리 루프의 정적 에셋 해싱 및 재할당 방지
seonghobae Jul 29, 2026
8bb8671
Merge branch 'master' into bolt/extract-static-assets-132496226799514…
opencode-agent[bot] Aug 3, 2026
5755d95
Merge branch 'master' into bolt/extract-static-assets-132496226799514…
opencode-agent[bot] Aug 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .jules/bolt.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,3 +43,6 @@
## 2025-01-24 - 단일 readAttributes 호출로 파일 속성 조회 최적화
**학습:** `isDirectory`, `!it.isDirectory()`, `isSymbolicLink` 3개의 개별적인 파일 시스템 I/O 호출을 수행하면 성능 저하가 큽니다. 이를 단일 `Files.readAttributes` 호출로 변경하여 메타데이터를 한 번에 조회함으로써 I/O 오버헤드를 대폭 줄일 수 있음을 확인했습니다.
**조치:** 디렉토리 순회 시 파일의 여러 속성을 확인할 때는 개별적인 stat 호출보다 `Files.readAttributes`를 사용하여 필요한 모든 속성을 한 번에 가져오는 방식을 우선적으로 고려해야 합니다.
## 2024-07-29 - 디렉토리 처리 루프의 정적 에셋 재할당 방지
**Learning:** 디렉토리 처리 루프(`process_dir`) 내에서 고정된 문자열 할당과 비용이 많이 드는 SHA-256 해시 계산이 반복적으로 발생하여 CPU 및 메모리 낭비가 발생했습니다. 또한 Kotlin에서 정적 변수를 추출할 때 컴파일러가 생성하는 암시적 getter로 인해 JaCoCo 테스트 커버리지가 떨어지는 문제가 있습니다.
**Action:** 대규모 정적 문자열과 결정론적 계산 결과를 `private object`로 추출하고, 100% 테스트 커버리지를 유지하기 위해 `const val` 및 `@JvmField`를 사용하도록 수정합니다.

@opencode-agent opencode-agent Bot Aug 4, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Unverified 100% coverage claim with no test/coverage execution evidence

  • Location: .jules/bolt.md:48
  • Problem: The new learning entry asserts the change keeps coverage at 100% ('100% 테스트 커버리지를 유지하기 위해 const val 및 @JvmField를 사용'), but the trusted Coverage execution evidence for head 5755d9 reports Result PASS as 'not applicable (no supported changed source files or package manifests)' and no OPENCODE_EXECUTION_RECEIPT shows ./gradlew test or a JaCoCo report at this head, so the coverage claim is unsupported.
  • Root cause: PR verification relies on the refactor being trivially coverage-neutral without executing the repository test/coverage contract; the coverage decision explicitly marks this change as not applicable.
  • Fix: Run ./gradlew test plus the JaCoCo report at head 5755d9 and attach the receipt/report, or soften the doc claim to state that coverage must be re-measured after the extraction.
  • Regression test: ./gradlew test

Suggested diff

```diff
-**Action:** 대규모 정적 문자열과 결정론적 계산 결과를 `private object`로 추출하고, 100% 테스트 커버리지를 유지하기 위해 `const val` 및 `@JvmField`를 사용하도록 수정합니다.
+**Action:** 대규모 정적 문자열과 결정론적 계산 결과를 `private object`로 추출해 재할당을 방지하고, `./gradlew test` 및 JaCoCo 리포트로 커버리지 100% 유지 여부를 재검증합니다.

42 changes: 24 additions & 18 deletions src/main/kotlin/html4tree/main.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,11 +240,12 @@ fun write_index_file(curr_dir: File, content: String) {
}
}

fun process_dir(curr_dir: File, excludeSet: Set<String>? = null, dirFiles: Array<File>? = null){

val exclude: Set<String> = excludeSet ?: process_ignore_file(curr_dir)

val cssContent = """
private object StaticAssets {

@opencode-agent opencode-agent Bot Aug 4, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 const val with string-template initializer does not compile in Kotlin

  • Location: src/main/kotlin/html4tree/main.kt:243
  • Problem: The extracted private object StaticAssets (opened at line 243) declares const val css = """<style>...${cssContent}...</style>""", whose initializer contains a string template. Kotlin constant expressions exclude string templates, so the Kotlin compiler rejects the initializer ('Const 'val' initializer should be a constant value'); the module cannot build, and process_dir/go — the CLI's core path — become unavailable. No execution receipt anywhere in bounded evidence shows this head compiling.
  • Root cause: The PR mixes two goals: hoisting static strings (valid) and forcing const to avoid JaCoCo implicit-getter coverage drops. const val requires a compile-time constant initializer; string interpolation is not a constant expression even when the interpolated value is itself const (cssContent).
  • Fix: Replace the template with constant string concatenation that yields byte-identical output — const val css = "\n <style>\n" + cssContent + " </style>\n \n" — or drop const and use a plain val/@JvmField val in the object (still computed once per process, preserving the stated optimization).
  • Regression test: ./gradlew test (test_commands) plus ./gradlew check (lint_commands); existing MainTest.kt (testGoRejectsRootDirectory, testCliMainParsing, testProcessDirHandlesNonDirectoryWithoutThrowing) and AttrExceptionTest.kt exercise process_dir and must pass after the fix.

Suggested diff

```diff
-    const val css = """
-              <style>
-${cssContent}              </style>
-              """
+    const val css = "\n              <style>\n" + cssContent + "              </style>\n              \n"

// ⚡ Bolt Performance Optimization: Extract static assets
// Prevents redundant string allocations and expensive SHA-256 hash recalculations
// on every process_dir loop iteration.
// Using const val and @JvmField avoids JaCoCo coverage drops from implicit getters.
const val cssContent = """
body {
font-family: system-ui, -apple-system, BlinkMacSystemFont, "Segoe UI", sans-serif;
line-height: 1.5;
Expand Down Expand Up @@ -313,25 +314,38 @@ fun process_dir(curr_dir: File, excludeSet: Set<String>? = null, dirFiles: Array
}
"""

val styleHash = "sha256-" + Base64.getEncoder().encodeToString(MessageDigest.getInstance("SHA-256").digest(cssContent.toByteArray(Charsets.UTF_8)))
@JvmField val styleHash = "sha256-" + Base64.getEncoder().encodeToString(MessageDigest.getInstance("SHA-256").digest(cssContent.toByteArray(Charsets.UTF_8)))

val css = """
const val css = """
<style>
${cssContent} </style>
"""

const val index_bottom="""
</ul>
</nav>
</main>
</body>
</html>
"""
}

fun process_dir(curr_dir: File, excludeSet: Set<String>? = null, dirFiles: Array<File>? = null){

val exclude: Set<String> = excludeSet ?: process_ignore_file(curr_dir)

val index_top = """<!doctype html>
<html lang="ko">
<head>
<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<meta name="color-scheme" content="light dark">
<!-- 보안 향상: 인라인 스크립트 실행 방지 -->
<meta http-equiv="Content-Security-Policy" content="default-src 'none'; style-src '${styleHash}'; base-uri 'none'; form-action 'none';">
<meta http-equiv="Content-Security-Policy" content="default-src 'none'; style-src '${StaticAssets.styleHash}'; base-uri 'none'; form-action 'none';">
<!-- 보안 향상: 리퍼러를 통한 디렉토리 경로 노출 방지 -->
<meta name="referrer" content="no-referrer">
<title>${curr_dir.getName().escapeHtml()}</title>
${css}
${StaticAssets.css}
</head>
<body>
<main>
Expand Down Expand Up @@ -380,16 +394,8 @@ ${cssContent} </style>
return l.toString();
}

val index_bottom="""
</ul>
</nav>
</main>
</body>
</html>
"""

try {
write_index_file(curr_dir, index_top+index_middle()+index_bottom)
write_index_file(curr_dir, index_top+index_middle()+StaticAssets.index_bottom)
} catch (e: Exception) {
// 보안 향상: 디렉토리에 쓰기 권한이 없거나 파일 시스템 오류가 발생했을 때
// 전체 크롤링(프로세스)이 중단되는 DoS를 방지합니다. (Fail Securely)
Expand Down
Loading