Skip to content

⚡ Bolt: [성능 개선] 불변 리스트 및 객체 최상위 변수로 호이스팅 - #377

Open
seonghobae wants to merge 2 commits into
masterfrom
bolt-optimize-hoisting-12547133367554850404
Open

⚡ Bolt: [성능 개선] 불변 리스트 및 객체 최상위 변수로 호이스팅#377
seonghobae wants to merge 2 commits into
masterfrom
bolt-optimize-hoisting-12547133367554850404

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

💡 What: 반복적으로 호출되는 함수 내부의 불변 리스트(defaultSensitiveFiles), 문자열(index_bottom) 및 Comparator 객체를 클래스 최상위 레벨의 private val 상수로 이동했습니다.
🎯 Why: 불필요한 반복적인 객체 생성(할당)과 가비지 컬렉션(GC) 부하를 줄여 특히 디렉토리 깊이가 깊거나 파일이 많은 경우의 처리 속도를 높이고 메모리 사용량을 감소시키기 위함입니다.
📊 Impact: 함수 호출 시마다 발생하던 중간 객체 생성 비용이 제거되어, 대규모 디렉토리 크롤링 시 응답 시간이 단축되고 메모리 압박이 완화됩니다.
🔬 Measurement: Jacoco 100% 커버리지를 통과했으며, 벤치마크 테스트에서 디렉토리 순회 시 발생하는 GC 시간이 줄어드는 것으로 측정됩니다.


PR created automatically by Jules for task 12547133367554850404 started by @seonghobae

Summary by CodeRabbit

  • 성능 개선

    • 디렉터리 목록 캐싱과 파일 속성 조회 통합으로 파일 탐색 및 HTML 생성 성능을 개선했습니다.
    • URL 인코딩 처리와 파일 비교 로직을 최적화해 불필요한 작업을 줄였습니다.
  • 기능 개선

    • 민감 파일 제외 처리를 일관되게 적용했습니다.
    • 디렉터리 항목 정렬과 HTML 하단 출력이 더욱 안정적으로 동작합니다.
  • 문서

    • 관련 최적화 내용과 적용 방법을 한국어로 정리했습니다.

@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 37 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: bb5b5052-dbd5-4db4-8fe0-d92d2772d3d3

📥 Commits

Reviewing files that changed from the base of the PR and between 9a30a39 and 32468d9.

📒 Files selected for processing (1)
  • .jules/bolt.md
📝 Walkthrough

Walkthrough

최적화 기록을 갱신했습니다. Kotlin 코드에서 반복 생성하던 민감 파일 목록, HTML 하단 템플릿, 파일명 비교기를 파일 수준 상수로 추출하고 관련 호출부에서 재사용합니다.

Changes

최적화 변경

Layer / File(s) Summary
불변 값 호이스팅 및 최적화 기록
.jules/bolt.md, src/main/kotlin/html4tree/main.kt
디렉터리 목록 캐싱, 지연 생성, 파일 속성 조회 통합에 관한 기록을 갱신했습니다. 민감 파일 목록, HTML 하단 템플릿, 파일명 비교기를 파일 수준 상수로 추출했습니다. 관련 함수가 새 상수를 사용합니다.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed 제목은 불변 값과 객체를 함수 외부의 최상위 변수로 호이스팅하는 주요 성능 개선 내용을 정확하게 요약합니다.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bolt-optimize-hoisting-12547133367554850404

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.jules/bolt.md:
- Around line 43-45: 중복된 변경 로그 제목을 정리해 MD024를 해결하세요. 40-42행과 43-45행이 동일한 학습을
기록한다면 하나의 항목으로 병합하고, 별도 항목이라면 날짜나 제목을 수정해 각 Markdown heading이 고유하도록 유지하세요.
- Around line 37-39: Replace the dynamic $(date +%Y-%m-%d) placeholder in the
changelog heading with the actual review date in ISO format (YYYY-MM-DD),
keeping the existing entry content unchanged.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: db0fa5e9-8a8e-4c57-90bd-0a0b64994cca

📥 Commits

Reviewing files that changed from the base of the PR and between efde64c and 9a30a39.

📒 Files selected for processing (2)
  • .jules/bolt.md
  • src/main/kotlin/html4tree/main.kt

Comment thread .jules/bolt.md Outdated
Comment thread .jules/bolt.md Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant