Skip to content

ci: fix mac/windows R-CMD-check — rebuild stringfish against installed RcppParallel - #77

Open
seonghobae wants to merge 13 commits into
developfrom
ci/rebuild-stringfish-abi
Open

ci: fix mac/windows R-CMD-check — rebuild stringfish against installed RcppParallel#77
seonghobae wants to merge 13 commits into
developfrom
ci/rebuild-stringfish-abi

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

All non-ubuntu R-CMD-check jobs — and on some snapshots the ubuntu jobs, test-fast, and test-suite — fail on every PR: loading kaefa dies because prebuilt CRAN/RSPM binaries that link RcppParallel's TBB were built before its oneTBB migration, which removed the legacy tbb::internal/tbb::task symbols:

stringfish.so: Symbol not found: __ZN3tbb8internal12NFS_AllocateEmmPv          (macOS)
stringfish.so: undefined symbol: _ZN3tbb8internal25concurrent_vector_base_...  (ubuntu)
qs2.so:        Symbol not found: __ZN3tbb4task13note_affinityEt                (macOS, after fixing stringfish)

It's upstream binary skew, not a code regression — develop last ran green 2026-07-13.

Fix: one step after setup-r-dependencies in each of the three workflows that rebuilds every installed package LinkingTo RcppParallel from source (tools::dependsOnPkgs("RcppParallel", dependencies = "LinkingTo")), so they all link the RcppParallel actually installed. Package-agnostic on purpose — the first attempt patched only stringfish and qs2 promptly failed the same way. Marked for removal once CRAN/RSPM binaries re-sync.

🤖 Generated with Claude Code

@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 9 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: dc8dbc77-5699-4246-9c80-b814a14ec63b

📥 Commits

Reviewing files that changed from the base of the PR and between 76a853a and fbba747.

📒 Files selected for processing (3)
  • .github/workflows/R-CMD-check.yaml
  • .github/workflows/test-fast.yaml
  • .github/workflows/test-suite.yaml

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant