fix(sqlite): make startup-owned stores safe for FastAPI worker threads - #41
fix(sqlite): make startup-owned stores safe for FastAPI worker threads#41seonghobae wants to merge 4 commits into
Conversation
|
Warning Review limit reached
Next review available in: 50 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
Comment |
|
Superseded by #42. The integration PR carries the SQLite worker-thread safety changes together with the federation API that exercises |
Pull request was closed
Summary
Fixes a production-only failure mode in the standalone account-unification service. FastAPI builds the SQLite config and audit objects during application startup, then executes synchronous route handlers in worker threads. Python's default SQLite connection rejects that cross-thread use, so runtime federation/config mutations and merge audit writes can fail with
sqlite3.ProgrammingErroreven though unit tests using in-memory fakes pass.Changes
SqliteKvStoreandSqliteAuditSink;Verification required
uv run pytest -quv run ruff check app tests toolsuv run interrogate .at 100%This is a prerequisite for the runtime federation registry in #18 and materially improves standalone reliability under real FastAPI request execution.