🛡️ Sentinel: [Medium] Prevent information disclosure in log-likelihood calculations - #39
Closed
seonghobae wants to merge 2 commits into
Closed
🛡️ Sentinel: [Medium] Prevent information disclosure in log-likelihood calculations#39seonghobae wants to merge 2 commits into
seonghobae wants to merge 2 commits into
Conversation
…d calculations Wrapped `dnorm` and `dmvnorm` calls in `try(..., silent = TRUE)` to prevent mathematical exceptions from leaking internal details to standard error.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
OpenCode cannot approve yet because required coverage evidence did not pass.
Review outcome
1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
-
Problem: The required coverage-evidence job result was
failure, so OpenCode cannot establish approval sufficiency for this head. -
Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.
-
Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports
successwith required evidence or explicit no-source not-applicable evidence. -
Regression test: Keep the approval branch checking
needs.coverage-evidence.result == successbefore posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present. -
Result: REQUEST_CHANGES
-
Reason: coverage-evidence result was
failure, so required test/docstring evidence was not proven for current head58554c68ee259209605c0dfb9678308f0616add4. -
Head SHA:
58554c68ee259209605c0dfb9678308f0616add4 -
Workflow run: 28992443248
-
Workflow attempt: 1
Coverage evidence
Coverage Evidence
- Head SHA:
58554c68ee259209605c0dfb9678308f0616add4 - Required test evidence: supported repository test suites must pass.
- Required docstring evidence: repository-owned docstring gates must pass when configured; otherwise docstring coverage is advisory.
R runtime install (r-base and package headers)
Get:1 file:/etc/apt/apt-mirrors.txt Mirrorlist [144 B]
Hit:2 http://azure.archive.ubuntu.com/ubuntu noble InRelease
Get:3 http://azure.archive.ubuntu.com/ubuntu noble-updates InRelease [126 kB]
Get:4 http://azure.archive.ubuntu.com/ubuntu noble-backports InRelease [126 kB]
Get:5 http://azure.archive.ubuntu.com/ubuntu noble-security InRelease [126 kB]
Get:6 https://dl.google.com/linux/chrome-stable/deb stable InRelease [1825 B]
Get:7 http://azure.archive.ubuntu.com/ubuntu noble-updates/main amd64 Packages [1079 kB]
Get:13 https://packages.microsoft.com/repos/azure-cli noble InRelease [3564 B]
Get:8 http://azure.archive.ubuntu.com/ubuntu noble-updates/main Translation-en [268 kB]
Get:9 http://azure.archive.ubuntu.com/ubuntu noble-updates/main amd64 Components [180 kB]
Get:10 http://azure.archive.ubuntu.com/ubuntu noble-updates/universe amd64 Packages [1659 kB]
Get:14 https://packages.microsoft.com/ubuntu/24.04/prod noble InRelease [3600 B]
Get:11 http://azure.archive.ubuntu.com/ubuntu noble-updates/universe amd64 Components [388 kB]
Get:12 http://azure.archive.ubuntu.com/ubuntu noble-updates/multiverse amd64 Components [940 B]
Get:15 http://azure.archive.ubuntu.com/ubuntu noble-backports/main amd64 Components [5768 B]
Get:16 http://azure.archive.ubuntu.com/ubuntu noble-backports/universe amd64 Components [10.5 kB]
Get:17 http://azure.archive.ubuntu.com/ubuntu noble-security/main amd64 Packages [827 kB]
Get:18 http://azure.archive.ubuntu.com/ubuntu noble-security/main Translation-en [187 kB]
Get:19 http://azure.archive.ubuntu.com/ubuntu noble-security/main amd64 Components [44.9 kB]
Get:20 http://azure.archive.ubuntu.com/ubuntu noble-security/main amd64 c-n-f Metadata [11.9 kB]
Get:21 http://azure.archive.ubuntu.com/ubuntu noble-security/universe amd64 Packages [1173 kB]
Get:22 http://azure.archive.ubuntu.com/ubuntu noble-security/universe Translation-en [230 kB]
Get:23 http://azure.archive.ubuntu.com/ubuntu noble-security/universe amd64 Components [76.3 kB]
Get:24 http://azure.archive.ubuntu.com/ubuntu noble-security/universe amd64 c-n-f Metadata [24.2 kB]
Get:25 https://dl.google.com/linux/chrome-stable/deb stable/main amd64 Packages [1220 B]
Get:26 https://packages.microsoft.com/repos/azure-cli noble/main amd64 Packages [2314 B]
Get:27 https://packages.microsoft.com/ubuntu/24.04/prod noble/main arm64 Packages [174 kB]
Get:28 https://packages.microsoft.com/ubuntu/24.04/prod noble/main armhf Packages [11.7 kB]
Get:29 https://packages.microsoft.com/ubuntu/24.04/prod noble/main amd64 Packages [207 kB]
Fetched 6950 kB in 1s (7297 kB/s)
Reading package lists...
Reading package lists...
Building dependency tree...
Reading state information...
libssl-dev is already the newest version (3.0.13-0ubuntu3.11).
libxml2-dev is already the newest version (2.9.14+dfsg-1.3ubuntu3.8).
libxml2-dev set to manually installed.
The following additional packages will be installed:
build-essential bzip2-doc libblas-dev libblas3 libbz2-dev libjpeg-dev
libjpeg-turbo8-dev libjpeg8-dev liblapack-dev liblapack3 liblzma-dev
libpaper-utils libpaper1 libpng-dev libpng-tools libreadline-dev r-base-core
r-base-dev r-base-html r-cran-boot r-cran-class r-cran-cluster
r-cran-codetools r-cran-foreign r-cran-kernsmooth r-cran-lattice r-cran-mass
r-cran-matrix r-cran-mgcv r-cran-nlme r-cran-nnet r-cran-rpart
r-cran-spatial r-cran-survival r-doc-html r-recommended
Suggested packages:
liblapack-doc libcurl4-doc libidn-dev libkrb5-dev libldap2-dev librtmp-dev
libssh2-1-dev liblzma-doc readline-doc elpa-ess r-doc-info | r-doc-pdf
r-mathlib texlive-base texlive-latex-base texlive-plain-generic
texlive-fonts-recommended texlive-fonts-extra texlive-extra-utils
texlive-latex-recommended texlive-latex-extra
The following NEW packages will be installed:
build-essential bzip2-doc libblas-dev libblas3 libbz2-dev
libcurl4-openssl-dev libjpeg-dev libjpeg-turbo8-dev libjpeg8-dev
liblapack-dev liblapack3 liblzma-dev libpaper-utils libpaper1 libpng-dev
libpng-tools libreadline-dev r-base r-base-core r-base-dev r-base-html
r-cran-boot r-cran-class r-cran-cluster r-cran-codetools r-cran-foreign
r-cran-kernsmooth r-cran-lattice r-cran-mass r-cran-matrix r-cran-mgcv
r-cran-nlme r-cran-nnet r-cran-rpart r-cran-spatial r-cran-survival
r-doc-html r-recommended
0 upgraded, 38 newly installed, 0 to remove and 20 not upgraded.
Need to get 58.4 MB of archives.
After this operation, 118 MB of additional disk space will be used.
Get:1 file:/etc/apt/apt-mirrors.txt Mirrorlist [144 B]
Get:2 http://azure.archive.ubuntu.com/ubuntu noble/main amd64 build-essential amd64 12.10ubuntu1 [4928 B]
Get:3 http://azure.archive.ubuntu.com/ubuntu noble-updates/main amd64 bzip2-doc all 1.0.8-5.1build0.1 [499 kB]
Get:4 http://azure.archive.ubuntu.com/ubuntu noble-updates/main amd64 libblas3 amd64 3.12.0-3build1.1 [238 kB]
Get:5 http://azure.archive.ubuntu.com/ubuntu noble-updates/main amd64 libblas-dev amd64 3.12.0-3build1.1 [170 kB]
Get:6 http://azure.archive.ubuntu.com/ubuntu noble-updates/main amd64 libbz2-dev amd64 1.0.8-5.1build0.1 [33.6 kB]
Get:7 http://azure.archive.ubuntu.com/ubuntu noble-updates/main amd64 libcurl4-openssl-dev amd64 8.5.0-2ubuntu10.10 [446 kB]
Get:8 http://azure.archive.ubuntu.com/ubuntu noble/main amd64 libjpeg-turbo8-dev amd64 2.1.5-2ubuntu2 [295 kB]
Get:9 http://azure.archive.ubuntu.com/ubuntu noble/main amd64 libjpeg8-dev amd64 8c-2ubuntu11 [1484 B]
Get:10 http://azure.archive.ubuntu.com/ubuntu noble/main amd64 libjpeg-dev amd64 8c-2ubuntu11 [1482 B]
Get:11 http://azure.archive.ubuntu.com/ubuntu noble-updates/main amd64 liblapack3 amd64 3.12.0-3build1.1 [2646 kB]
Get:12 http://azure.archive.ubuntu.com/ubuntu noble-updates/main amd64 liblapack-dev amd64 3.12.0-3build1.1 [5196 kB]
Get:13 http://azure.archive.ubuntu.com/ubuntu noble/main amd64 libpaper1 amd64 1.1.29build1 [13.4 kB]
Get:14 http://azure.archive.ubuntu.com/ubuntu noble/main amd64 libpaper-utils amd64 1.1.29build1 [8650 B]
Get:15 http://azure.archive.ubuntu.com/ubuntu noble-updates/main amd64 libpng-dev amd64 1.6.43-5ubuntu0.6 [265 kB]
Get:16 http://azure.archive.ubuntu.com/ubuntu noble-updates/main amd64 libpng-tools amd64 1.6.43-5ubuntu0.6 [28.5 kB]
Get:17 http://azure.archive.ubuntu.com/ubuntu noble/main amd64 libreadline-dev amd64 8.2-4build1 [167 kB]
Get:18 http://azure.archive.ubuntu.com/ubuntu noble/universe amd64 r-base-core amd64 4.3.3-2build2 [27.1 MB]
Get:19 http://azure.archive.ubuntu.com/ubuntu noble/universe amd64 r-cran-boot all 1.3-30-1 [619 kB]
Get:20 http://azure.archive.ubuntu.com/ubuntu noble/universe amd64 r-cran-cluster amd64 2.1.6-1build1 [553 kB]
Get:21 http://azure.archive.ubuntu.com/ubuntu noble/universe amd64 r-cran-foreign amd64 0.8.86-1build1 [242 kB]
Get:22 http://azure.archive.ubuntu.com/ubuntu noble/universe amd64 r-cran-mass amd64 7.3-60.0.1-1 [1119 kB]
Get:23 http://azure.archive.ubuntu.com/ubuntu noble/universe amd64 r-cran-kernsmooth amd64 2.23-22-1build1 [91.8 kB]
Get:24 http://azure.archive.ubuntu.com/ubuntu noble/universe amd64 r-cran-lattice amd64 0.22-5-1build1 [1341 kB]
Get:25 http://azure.archive.ubuntu.com/ubuntu noble/universe amd64 r-cran-nlme amd64 3.1.164-1build1 [2261 kB]
Get:26 http://azure.archive.ubuntu.com/ubuntu noble/universe amd64 r-cran-matrix amd64 1.6-5-1 [3830 kB]
Get:27 http://azure.archive.ubuntu.com/ubuntu noble/universe amd64 r-cran-mgcv amd64 1.9-1-1 [3252 kB]
Get:28 http://azure.archive.ubuntu.com/ubuntu noble/universe amd64 r-cran-survival amd64 3.5-8-1 [6120 kB]
Get:29 http://azure.archive.ubuntu.com/ubuntu noble/universe amd64 r-cran-rpart amd64 4.1.23-1build1 [661 kB]
Get:30 http://azure.archive.ubuntu.com/ubuntu noble/universe amd64 r-cran-class amd64 7.3-22-2build1 [88.2 kB]
Get:31 http://azure.archive.ubuntu.com/ubuntu noble/universe amd64 r-cran-nnet amd64 7.3-19-2build1 [112 kB]
Get:32 http://azure.archive.ubuntu.com/ubuntu noble/universe amd64 r-cran-spatial amd64 7.3-17-1build1 [132 kB]
Get:33 http://azure.archive.ubuntu.com/ubuntu noble/universe amd64 r-cran-codetools all 0.2-19-1 [90.5 kB]
Get:34 http://azure.archive.ubuntu.com/ubuntu noble/universe amd64 r-recommended all 4.3.3-2build2 [2636 B]
Get:35 http://azure.archive.ubuntu.com/ubuntu noble/universe amd64 r-base all 4.3.3-2build2 [9304 B]
Get:36 http://azure.archive.ubuntu.com/ubuntu noble-updates/main amd64 liblzma-dev amd64 5.6.1+really5.4.5-1ubuntu0.3 [176 kB]
Get:37 http://azure.archive.ubuntu.com/ubuntu noble/universe amd64 r-base-dev all 4.3.3-2build2 [4334 B]
Get:38 http://azure.archive.ubuntu.com/ubuntu noble/universe amd64 r-doc-html all 4.3.3-2build2 [587 kB]
Get:39 http://azure.archive.ubuntu.com/ubuntu noble/universe amd64 r-base-html all 4.3.3-2build2 [58.1 kB]
Preconfiguring packages ...
Fetched 58.4 MB in 7s (7899 kB/s)
Selecting previously unselected package build-essential.
(Reading database ...
(Reading database ... 5%
(Reading database ... 10%
(Reading database ... 15%
(Reading database ... 20%
(Reading database ... 25%
(Reading database ... 30%
(Reading database ... 35%
(Reading database ... 40%
(Reading database ... 45%
(Reading database ... 50%
(Reading database ... 55%
(Reading database ... 60%
(Reading database ... 65%
(Reading database ... 70%
(Reading database ... 75%
(Reading database ... 80%
(Reading database ... 85%
(Reading database ... 90%
(Reading database ... 95%
(Reading database ... 100%
(Reading database ... 202701 files and directories currently installed.)
Preparing to unpack .../00-build-essential_12.10ubuntu1_amd64.deb ...
Unpacking build-essential (12.10ubuntu1) ...
Selecting previously unselected package bzip2-doc.
Preparing to unpack .../01-bzip2-doc_1.0.8-5.1build0.1_all.deb ...
Unpacking bzip2-doc (1.0.8-5.1build0.1) ...
Selecting previously unselected package libblas3:amd64.
Preparing to unpack .../02-libblas3_3.12.0-3build1.1_amd64.deb ...
Unpacking libblas3:amd64 (3.12.0-3build1.1) ...
Selecting previously unselected package libblas-dev:amd64.
Preparing to unpack .../03-libblas-dev_3.12.0-3build1.1_amd64.deb ...
Unpacking libblas-dev:amd64 (3.12.0-3build1.1) ...
Selecting previously unselected package libbz2-dev:amd64.
Preparing to unpack .../04-libbz2-dev_1.0.8-5.1build0.1_amd64.deb ...
Unpacking libbz2-dev:amd64 (1.0.8-5.1build0.1) ...
Selecting previously unselected package libcurl4-openssl-dev:amd64.
Preparing to unpack .../05-libcurl4-openssl-dev_8.5.0-2ubuntu10.10_amd64.deb ...
Unpacking libcurl4-openssl-dev:amd64 (8.5.0-2ubuntu10.10) ...
Selecting previously unselected package libjpeg-turbo8-dev:amd64.
Preparing to unpack .../06-libjpeg-turbo8-dev_2.1.5-2ubuntu2_amd64.deb ...
Unpacking libjpeg-turbo8-dev:amd64 (2.1.5-2ubuntu2) ...
Selecting previously unselected package libjpeg8-dev:amd64.
Preparing to unpack .../07-libjpeg8-dev_8c-2ubuntu11_amd64.deb ...
Unpacking libjpeg8-dev:amd64 (8c-2ubuntu11) ...
Selecting previously unselected package libjpeg-dev:amd64.
Preparing to unpack .../08-libjpeg-dev_8c-2ubuntu11_amd64.deb ...
Unpacking libjpeg-dev:amd64 (8c-2ubuntu11) ...
Selecting previously unselected package liblapack3:amd64.
Preparing to unpack .../09-liblapack3_3.12.0-3build1.1_amd64.deb ...
Unpacking liblapack3:amd64 (3.12.0-3build1.1) ...
Selecting previously unselected package liblapack-dev:amd64.
Preparing to unpack .../10-liblapack-dev_3.12.0-3build1.1_amd64.deb ...
Unpacking liblapack-dev:amd64 (3.12.0-3build1.1) ...
Selecting previously unselected package libpaper1:amd64.
Preparing to unpack .../11-libpaper1_1.1.29build1_amd64.deb ...
Unpacking libpaper1:amd64 (1.1.29build1) ...
Selecting previously unselected package libpaper-utils.
Preparing to unpack .../12-libpaper-utils_1.1.29build1_amd64.deb ...
Unpacking libpaper-utils (1.1.29build1) ...
Selecting previously unselected package libpng-dev:amd64.
Preparing to unpack .../13-libpng-dev_1.6.43-5ubuntu0.6_amd64.deb ...
Unpacking libpng-dev:amd64 (1.6.43-5ubuntu0.6) ...
Selecting previously unselected package libpng-tools.
Preparing to unpack .../14-libpng-tools_1.6.43-5ubuntu0.6_amd64.deb ...
Unpacking libpng-tools (1.6.43-5ubuntu0.6) ...
Selecting previously unselected package libreadline-dev:amd64.
Preparing to unpack .../15-libreadline-dev_8.2-4build1_amd64.deb ...
Unpacking libreadline-dev:amd64 (8.2-4build1) ...
Selecting previously unselected package r-base-core.
Preparing to unpack .../16-r-base-core_4.3.3-2build2_amd64.deb ...
Unpacking r-base-core (4.3.3-2build2) ...
Selecting previously unselected package r-cran-boot.
Preparing to unpack .../17-r-cran-boot_1.3-30-1_all.deb ...
Unpacking r-cran-boot (1.3-30-1) ...
Selecting previously unselected package r-cran-cluster.
Preparing to unpack .../18-r-cran-cluster_2.1.6-1build1_amd64.deb ...
Unpacking r-cran-cluster (2.1.6-1build1) ...
Selecting previously unselected package r-cran-foreign.
Preparing to unpack .../19-r-cran-foreign_0.8.86-1build1_amd64.deb ...
Unpacking r-cran-foreign (0.8.86-1build1) ...
Selecting previously unselected package r-cran-mass.
Preparing to unpack .../20-r-cran-mass_7.3-60.0.1-1_amd64.deb ...
Unpacking r-cran-mass (7.3-60.0.1-1) ...
Selecting previously unselected package r-cran-kernsmooth.
Preparing to unpack .../21-r-cran-kernsmooth_2.23-22-1build1_amd64.deb ...
Unpacking r-cran-kernsmooth (2.23-22-1build1) ...
Selecting previously unselected package r-cran-lattice.
Preparing to unpack .../22-r-cran-lattice_0.22-5-1build1_amd64.deb ...
Unpacking r-cran-lattice (0.22-5-1build1) ...
Selecting previously unselected package r-cran-nlme.
Preparing to unpack .../23-r-cran-nlme_3.1.164-1build1_amd64.deb ...
Unpacking r-cran-nlme (3.1.164-1build1) ...
Selecting previously unselected package r-cran-matrix.
Preparing to unpack .../24-r-cran-matrix_1.6-5-1_amd64.deb ...
Unpacking r-cran-matrix (1.6-5-1) ...
Selecting previously unselected package r-cran-mgcv.
Preparing to unpack .../25-r-cran-mgcv_1.9-1-1_amd64.deb ...
Unpacking r-cran-mgcv (1.9-1-1) ...
Selecting previously unselected package r-cran-survival.
Preparing to unpack .../26-r-cran-survival_3.5-8-1_amd64.deb ...
Unpacking r-cran-survival (3.5-8-1) ...
Selecting previously unselected package r-cran-rpart.
Preparing to unpack .../27-r-cran-rpart_4.1.23-1build1_amd64.deb ...
Unpacking r-cran-rpart (4.1.23-1build1) ...
Selecting previously unselected package r-cran-class.
Preparing to unpack .../28-r-cran-class_7.3-22-2build1_amd64.deb ...
Unpacking r-cran-class (7.3-22-2build1) ...
Selecting previously unselected package r-cran-nnet.
Preparing to unpack .../29-r-cran-nnet_7.3-19-2build1_amd64.deb ...
Unpacking r-cran-nnet (7.3-19-2build1) ...
Selecting previously unselected package r-cran-spatial.
Preparing to unpack .../30-r-cran-spatial_7.3-17-1build1_amd64.deb ...
Unpacking r-cran-spatial (7.3-17-1build1) ...
Selecting previously unselected package r-cran-codetools.
Preparing to unpack .../31-r-cran-codetools_0.2-19-1_all.deb ...
Unpacking r-cran-codetools (0.2-19-1) ...
Selecting previously unselected package r-recommended.
Preparing to unpack .../32-r-recommended_4.3.3-2build2_all.deb ...
Unpacking r-recommended (4.3.3-2build2) ...
Selecting previously unselected package r-base.
Preparing to unpack .../33-r-base_4.3.3-2build2_all.deb ...
Unpacking r-base (4.3.3-2build2) ...
Selecting previously unselected package liblzma-dev:amd64.
Preparing to unpack .../34-liblzma-dev_5.6.1+really5.4.5-1ubuntu0.3_amd64.deb ...
Unpacking liblzma-dev:amd64 (5.6.1+really5.4.5-1ubuntu0.3) ...
Selecting previously unselected package r-base-dev.
Preparing to unpack .../35-r-base-dev_4.3.3-2build2_all.deb ...
Unpacking r-base-dev (4.3.3-2build2) ...
Selecting previously unselected package r-doc-html.
Preparing to unpack .../36-r-doc-html_4.3.3-2build2_all.deb ...
Unpacking r-doc-html (4.3.3-2build2) ...
Selecting previously unselected package r-base-html.
Preparing to unpack .../37-r-base-html_4.3.3-2build2_all.deb ...
Unpacking r-base-html (4.3.3-2build2) ...
Setting up bzip2-doc (1.0.8-5.1build0.1) ...
- Result: PASS
R coverage tooling (covr/testthat)
also installing the dependencies ‘sys’, ‘askpass’, ‘curl’, ‘mime’, ‘openssl’, ‘R6’, ‘digest’, ‘jsonlite’, ‘rex’, ‘httr’, ‘cli’, ‘withr’, ‘yaml’
trying URL 'https://cloud.r-project.org/src/contrib/sys_3.4.3.tar.gz'
Content type 'application/x-gzip' length 19936 bytes (19 KB)
## Changed-File Evidence Map
```mermaid
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file (2 files)"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file (2 files)"]
R1 --> V1["required checks"]
OpenCode Review Overview
Pull request overviewOpenCode cannot approve yet because required coverage evidence did not pass. Review outcome1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
Coverage evidenceCoverage Evidence
R runtime install (r-base and package headers)
R coverage tooling (covr/testthat) |
…d calculations Wrapped `dnorm` and `dmvnorm` calls in `try(..., silent = TRUE)` to prevent mathematical exceptions from leaking internal details to standard error.
Collaborator
Author
|
Closing as superseded by #41, merged as Current The remaining unique change in this PR wraps |
Understood. Acknowledging that this work is now obsolete and stopping work on this task. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚨 Severity: MEDIUM
💡 Vulnerability: Information Disclosure.
try()defaults tosilent = FALSE, leaking mathematical exceptions (e.g., matrix singularity details) to standard error.dnormcalls weren't wrapped intry.🎯 Impact: Leaks internal implementation details.
🔧 Fix: Wrapped calls in
try(..., silent = TRUE).✅ Verification: Ran tests via
Rscript -e "testthat::test_dir('tests/testthat/')"and verified no standard error leaks occur on math exceptions.PR created automatically by Jules for task 15197034089479183150 started by @seonghobae