⚡ Bolt: [performance improvement] Optimize edge column lookups in exportDDL - #588
⚡ Bolt: [performance improvement] Optimize edge column lookups in exportDDL#588seonghobae wants to merge 1 commit into
Conversation
Pre-compute column handle mappings to replace O(N) array scans with O(1) Map lookups when resolving foreign key columns during DDL generation.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
There was a problem hiding this comment.
Pull request overview
OpenCode cannot approve yet because required coverage evidence did not pass.
Review outcome
1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
-
Problem: The required coverage-evidence job result was
failure, so OpenCode cannot establish approval sufficiency for this head. -
Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.
-
Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports
successwith required evidence or explicit no-source not-applicable evidence. -
Regression test: Keep the approval branch checking
needs.coverage-evidence.result == successbefore posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present. -
Result: REQUEST_CHANGES
-
Reason: coverage-evidence result was
failure, so required test/docstring evidence was not proven for current head87b66508fb0c6b64f773c7bda76fdab26c00e959. -
Head SHA:
87b66508fb0c6b64f773c7bda76fdab26c00e959 -
Workflow run: 29649233860
-
Workflow attempt: 1
Coverage evidence
Coverage evidence job did not run or did not publish coverage evidence.
Changed-File Evidence Map
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file: bolt.md"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file: bolt.md"]
R1 --> V1["required checks"]
Evidence --> S2["Frontend: export.ts"]
S2 --> I2["browser runtime and bundle"]
I2 --> R2["Review risk: Frontend: export.ts"]
R2 --> V2["frontend tests"]
OpenCode Review Overview
Pull request overviewOpenCode cannot approve yet because required coverage evidence did not pass. Review outcome1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
Coverage evidenceCoverage evidence job did not run or did not publish coverage evidence. Changed-File Evidence Mapflowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file: bolt.md"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file: bolt.md"]
R1 --> V1["required checks"]
Evidence --> S2["Frontend: export.ts"]
S2 --> I2["browser runtime and bundle"]
I2 --> R2["Review risk: Frontend: export.ts"]
R2 --> V2["frontend tests"]
|
💡 What: Optimizes
fkColumnsForEdgein the ERD exporter to use an optional pre-computedhandleToColmap for resolving foreign key column handles, reducing complexity.🎯 Why: During DDL export,$O(E \times C)$ bottleneck.
exportDDLiterated through every edge and calledfkColumnsForEdge, which previously used array.find()to scan the entire columns list of both the source and target nodes to match handle IDs. This resulted in an📊 Impact: Decreases export time complexity for handling edge column mapping from$O(E \times C)$ to $O(E + V \times C)$ , significantly speeding up the DDL generation process for large schemas and reducing unnecessary garbage collection pressure from intermediate closures.
🔬 Measurement: Verify tests still pass:
cd frontend && pnpm run typecheck && pnpm test && pnpm run build. The resulting DDL output should remain functionally identical.PR created automatically by Jules for task 11794925502051570268 started by @seonghobae