⚡ Bolt: Optimize ERD edge column resolution to O(1) using reverse-parsing - #647
⚡ Bolt: Optimize ERD edge column resolution to O(1) using reverse-parsing#647seonghobae wants to merge 1 commit into
Conversation
Added `parseColumnNameFromHandle` to directly reverse-engineer original column names from the encoded React Flow connection strings. Replaced all O(N*C) node column iterative matching searches inside ERD export builders (DBML, DDL, Mermaid, and Data Dictionary) with the O(1) direct decode strategy.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Warning Review limit reached
Next review available in: 38 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (6)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Pull request overview
This PR optimizes ERD export-time foreign key (FK) column resolution by decoding column names directly from React Flow handle IDs (hex-encoded), avoiding per-edge scans over table columns and reducing intermediate string allocations in large diagrams.
Changes:
- Added
parseColumnNameFromHandleto reverse-decodesrc-c-*/tgt-c-*(andc-*) handles back into raw column names. - Refactored FK column resolution in export flows to prefer direct handle parsing, with fallbacks to prior lookup behavior.
- Updated handle utility tests and documented the performance lesson in
.jules/bolt.md.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| frontend/src/erd/handleUtils.ts | Adds reverse parsing utility to decode column names from handle IDs. |
| frontend/src/erd/handleUtils.test.ts | Updates tests for new parsing behavior and existing handle encoding helpers. |
| frontend/src/erd/exportDataDictionary.ts | Uses parsed source-handle column names to mark FK columns without per-column handle regeneration. |
| frontend/src/erd/export.ts | Uses parsed handle decoding in fkColumnsForEdge to avoid O(columns) scans for common cases. |
| frontend/src/erd/dbml.ts | Fixes DBML relationship emission to use decoded column names instead of internal handle strings. |
| .jules/bolt.md | Records the optimization approach and rationale for future reference. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| const match = handleId.match(/^(?:src-|tgt-)?c-(.+)$/); | ||
| if (!match) return null; | ||
| const encoded = match[1]; | ||
| if (encoded === 'empty') return ''; | ||
|
|
||
| try { | ||
| return encoded | ||
| .split('-') | ||
| .map((hex) => String.fromCodePoint(parseInt(hex, 16))) | ||
| .join(''); | ||
| } catch (e) { | ||
| return null; | ||
| } |
| test('parses naked handle correctly', () => { | ||
| expect(parseColumnNameFromHandle('c-0075-0073-0065-0072-005f-0069-0064')).toBe('user_id'); | ||
| }); | ||
|
|
||
| describe('sourceColumnHandleId', () => { | ||
| it('should prepend src- to sanitized id', () => { | ||
| expect(sourceColumnHandleId('id')).toBe('src-c-0069-0064'); | ||
| }); | ||
| test('returns empty string for c-empty', () => { |
💡 What:
Introduced a
parseColumnNameFromHandleutility to directly extract the original column name from hex-encodedsrc-c-*ortgt-c-*React Flow handles. Refactored the ERD export methods (exportDDL,exportDbml,exportMermaid,exportDataDictionary) to use this direct parsing utility instead of dynamically re-generating strings and iterating through the column list of the node.🎯 Why:
During exports involving many nodes and edges, resolving a foreign key connection required iterating through all columns of a source or target table and generating encoded handles for every single column to see which one matched the incoming edge (
O(E * C)worst case). This caused a large amount of array allocation and heavy string transformation within tight loops. The handles actually natively carry the hex-encoded column name. Reverse parsing transforms this back into anO(1)string decoding process, completely removing the array looping bottlenecks.📊 Impact:
🔬 Measurement:
PR created automatically by Jules for task 12133381397972216538 started by @seonghobae