⚡ Bolt: [performance improvement] Optimize ERD exports with O(1) handle parsing - #676
⚡ Bolt: [performance improvement] Optimize ERD exports with O(1) handle parsing#676seonghobae wants to merge 1 commit into
Conversation
Replaced O(N*C) handle string encoding during ERD exports with an O(1) parseColumnNameFromHandle utility that reverses sanitizeHandleId. This drastically reduces CPU usage and garbage collection overhead during export generation.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
| import type { IndexRecommendation } from './cardinality'; | ||
| import type { ForeignKeyEdgeData, TableNodeData } from './convert'; | ||
| import { sourceColumnHandleId, targetColumnHandleId } from './handleUtils'; | ||
| import { sourceColumnHandleId, targetColumnHandleId, parseColumnNameFromHandle } from './handleUtils'; |
|
Warning Review limit reached
Next review available in: 42 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (9)
Comment |
1 participant
💡 What:$O(1)$ . Replaced usages of $O(1)$ decoding of edge handles. Added comprehensive tests.
Added a
parseColumnNameFromHandleutility that decodessanitizeHandleIdstrings back to their original column names insourceColumnHandleId/targetColumnHandleIdinside array scans inexport.ts,exportDataDictionary.ts,mermaid.ts, anddbml.tswith upfront🎯 Why:$O(N)$ or $O(E)$ loops, causing massive CPU string-encoding overhead and garbage collection pressure due to generating hex strings for every node in large graphs.
During ERD exports (DDL, DBML, Dictionary, Mermaid), checking relationships required matching column names against edge handles. The previous implementation called
sanitizeHandleId(columnName)on every single column in the schema inside📊 Impact:$O(N \times C)$ string allocation bottleneck into an $O(1)$ lookup and native string comparison.
Significantly reduces GC pressure and execution time for exporting schemas with thousands of columns by transforming an
🔬 Measurement:
Profile generating exports (like DBML or Mermaid) on a large schema and observe the reduction in memory spikes and execution time. All tests run via
cd frontend && pnpm run typecheck && pnpm test && pnpm run buildcontinue to pass.PR created automatically by Jules for task 4909398645755318232 started by @seonghobae